Skip to content

Migrate package manager from npm to pnpm #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mahata merged 1 commit into from
Apr 7, 2026
Merged

Migrate package manager from npm to pnpm #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,23 @@ jobs:
- name: Checkout
uses: actions/checkout@v6

- name: Setup pnpm
uses: pnpm/action-setup@v4

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow sets up pnpm via pnpm/action-setup@v4 but doesn’t pin the pnpm version. Since package.json now pins pnpm via the packageManager field (pnpm@10.33.0) and pnpm-lock.yaml is lockfileVersion 9 (pnpm 10), CI should explicitly install that version (or enable Corepack and rely on packageManager) to avoid accidental breakage if the action’s default changes.

Suggested change
uses: pnpm/action-setup@v4
uses: pnpm/action-setup@v4
with:
version: 10.33.0

Copilot uses AI. Check for mistakes.

- name: Setup Node.js
uses: actions/setup-node@v6
with:
node-version: 22
cache: npm
cache: pnpm

- name: Install dependencies
run: npm ci
run: pnpm install --frozen-lockfile

- name: Run tests
run: npm test
run: pnpm test

- name: Type check
run: npm run check
run: pnpm run check

- name: Build site
run: npm run build
run: pnpm run build
13 changes: 8 additions & 5 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,26 @@ jobs:
- name: Checkout
uses: actions/checkout@v6

- name: Setup pnpm
uses: pnpm/action-setup@v4

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow sets up pnpm via pnpm/action-setup@v4 but doesn’t pin the pnpm version. Since package.json now pins pnpm via the packageManager field (pnpm@10.33.0) and pnpm-lock.yaml is lockfileVersion 9 (pnpm 10), the deploy workflow should explicitly install that version (or enable Corepack and rely on packageManager) to keep builds deterministic.

Suggested change
uses: pnpm/action-setup@v4
uses: pnpm/action-setup@v4
with:
version: 10.33.0

Copilot uses AI. Check for mistakes.

- name: Setup Node.js
uses: actions/setup-node@v6
with:
node-version: 22
cache: npm
cache: pnpm

- name: Install dependencies
run: npm ci
run: pnpm install --frozen-lockfile

- name: Run tests
run: npm test
run: pnpm test

- name: Type check
run: npm run check
run: pnpm run check

- name: Build site
run: npm run build
run: pnpm run build

- name: Upload artifact
uses: actions/upload-pages-artifact@v4
Expand Down
14 changes: 7 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,20 @@ Blog powered by [Astro](https://astro.build).
## Commands

```bash
npm run dev # Start dev server
npm run build # Build for production
npm run preview # Preview production build
npm test # Run unit tests
npm run check # Run type checking
pnpm run dev # Start dev server
pnpm run build # Build for production
pnpm run preview # Preview production build
pnpm test # Run unit tests
pnpm run check # Run type checking
```

## Writing Posts

Scaffold a new post with:

```bash
npm run new-post -- "My Post Title"
npm run new-post -- "My Draft Post" --draft
pnpm run new-post -- "My Post Title"
pnpm run new-post -- "My Draft Post" --draft
```

This creates a file like `src/content/blog/2024-01-15-my-post-title.md` with the frontmatter pre-filled.
Expand Down
Loading
Loading