Skip to content

Loosen the upper bound in SocketTest timeout tests - #1891

Open
hippi345 wants to merge 1 commit into
lysine-dev:mainfrom
hippi345:socket-timeout-test-bounds
Open

hippi345 wants to merge 1 commit into
lysine-dev:mainfrom
hippi345:socket-timeout-test-bounds

Conversation

@hippi345

Copy link
Copy Markdown

SocketTest.readTimeout failed on CI at ~825 ms against the 250–750 ms window. The 500 ms timeout fires fine; a busy runner just takes a while to deliver the interrupt.

This keeps the 250 ms lower bound (so a timeout that fires too early still fails) and raises the upper bound to 2 s, which is only there to catch a hang. writeTimeout uses the same window, so I changed it too.

./gradlew :okio:jvmTest --tests okio.SocketTest (20 passed) and spotlessCheck pass locally.

Closes #1886

readTimeout failed on CI at 825 ms against a 750 ms cap. Keep the 250 ms
lower bound, which checks that the timeout doesn't fire early, and only use
the upper bound to catch a hang. writeTimeout has the same bound and gets
the same change.

Closes lysine-dev#1886

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

SocketTest.readTimeout flaky

1 participant