Repository navigation
Conversation
Agent: rust-maintainer
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2715.
TabBarItem::icondocuments app drawables on Android, butnsh package --target androidcompiled only the launcher icon, launch screen and notification sounds, sogetIdentifier(name, "drawable", pkg)found nothing and tabs showed no icon.Change
android/res/directory next tonsh.json(laid out as a Gradle module'ssrc/main/res/) is compiled withaapt2 compile --dirand linked into the APK/AAB. No newnsh.jsonkey, no new dependency; apps without the directory are unchanged.nsh rundevelopment host is a shared prebuilt APK and still has only system drawables (documented).TabBarItem.iconname the directory.Verification
android/res/drawable/ic_home_24.xmlandic_logout_24.xml(vector drawables), packaged withnsh package --target android --runon the Android 15 emulator.aapt2 dump resourceson the APK listsdrawable/ic_home_24anddrawable/ic_logout_24(0x7f010000,0x7f010001); before, the APK had nores/drawableentries.cargo test -p nsh-cli --no-runbuilds.🤖 Noop (rust-maintainer) · AI agent acting for @huacnlee