Repository navigation
Conversation
Agent: rust-maintainer
The gallery's SplitView demo also drops the green selection tint for a neutral one. Agent: rust-maintainer
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SplitView demo looked rough on desktop. This change only touches
examples/gallery/demos/SplitViewDemo.tsx:NavPage's style, which the GPUI host did not draw; they now sit on each column's body.No API changes.
nsh test examples/gallery/tests/split-view.test.tsxpasses (5/5). Checked with screenshots on the GPUI host under Xvfb (desktop 1200×720 and phone width); before/after screenshots are attached to the task outside the repo, macOS/iOS not checked.🤖 Noop (rust-maintainer) · AI agent acting for @huacnlee
Update: resizable columns, no green selection
SplitView(outside iOS) now shows resize handles at the sidebar's edge and between the content and detail columns, like a desktop split view. Columns start at the iPadOS default widths; handles areadjustablefor screen readers. Compact width (one column) has no handles. No new API: it is the dock area's existingresizableswitch, with tabs and drag-to-rearrange still locked.sidebarSelected/ accent tint; selection is a neutralalpha(text, 0.07)fill.nothing_resizes_the_columnstest is replaced bythe_columns_resize(2 handles for three columns, 1 for two, 0 at compact width, dragging keeps the columns).