Skip to content

base: split_view: Make columns resizable and polish the gallery demo - #2734

Open
huacnlee wants to merge 2 commits into
mainfrom
agent/T-10493-splitview-demo
Open

huacnlee wants to merge 2 commits into
mainfrom
agent/T-10493-splitview-demo

Conversation

@huacnlee

@huacnlee huacnlee commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

The SplitView demo looked rough on desktop. This change only touches examples/gallery/demos/SplitViewDemo.tsx:

  • Column hairlines now actually show: they were set on NavPage's style, which the GPUI host did not draw; they now sit on each column's body.
  • Message rows are inset, rounded rows with the sidebar's neutral selection instead of full-width rows tinted with the accent and separated by hairlines; the unread dot is smaller.
  • The message pane no longer repeats the subject as a large heading under the header that already shows it; a hairline separates the sender from the body.
  • The sender's avatar uses a neutral fill instead of the accent tint.

No API changes. nsh test examples/gallery/tests/split-view.test.tsx passes (5/5). Checked with screenshots on the GPUI host under Xvfb (desktop 1200×720 and phone width); before/after screenshots are attached to the task outside the repo, macOS/iOS not checked.

🤖 Noop (rust-maintainer) · AI agent acting for @huacnlee

Update: resizable columns, no green selection

  • SplitView (outside iOS) now shows resize handles at the sidebar's edge and between the content and detail columns, like a desktop split view. Columns start at the iPadOS default widths; handles are adjustable for screen readers. Compact width (one column) has no handles. No new API: it is the dock area's existing resizable switch, with tabs and drag-to-rearrange still locked.
  • The demo's selected rows and icons no longer use the green sidebarSelected / accent tint; selection is a neutral alpha(text, 0.07) fill.
  • Docs (en, zh-CN) updated; the nothing_resizes_the_columns test is replaced by the_columns_resize (2 handles for three columns, 1 for two, 0 at compact width, dragging keeps the columns).
  • Screenshots for this update are still to come: this host's Xvfb renders the GPUI window black.

Agent: rust-maintainer
The gallery's SplitView demo also drops the green selection tint for a
neutral one.

Agent: rust-maintainer
@huacnlee huacnlee changed the title gallery: Polish the SplitView demo base: split_view: Make columns resizable and polish the gallery demo Nov 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant