Repository navigation
Make oversampling work on LM20A - #117
Merged
Merged
Conversation
Owner
|
Thanks for finding this and sharing the test sketch. I've included your contribution in 1.0.21, with the burst setting applied globally on LM20A and additional coverage for channels 1 and 7. The connected LM20A passed three complete 36-case test sweeps. Could you give 1.0.21 another run on your L15 and LM20A when you have a chance? |
Contributor
Author
I tested with 1.0.22, and oversampling works fine now on both XIAO nRF54L15 and nRF54LM20A. Thx for your effort! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the BURST control has moved to a separate register with nRF54LM20A, oversampling currently doesn't work with this chip. The patch fixed that.
Arduino sketch to test changes (tested with XIAO nRF54LM20A and XIAO nRF54L15):
With Arduino serial plotter, one can easily see the less noisy signal with oversampling 😸