Repository navigation
tests: use the platform temp dir instead of hardcoded /tmp - #633
Merged
Merged
Conversation
/tmp does not exist on Android/Termux, so keyfile_dump_load failed with EACCES. std::env::temp_dir() respects the platform; fixed filename replaced to avoid parallel-run collisions.
A6GibKm
approved these changes
Nov 3, 2026
Collaborator
|
Thanks |
📊 Code Coverage Report
Coverage report generated by cargo-tarpaulin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
keyfile_dump_loadfailing with EACCES on systems without a writable/tmp(e.g. Android/Termux app sandboxes), and removes a fixed filename that two parallel test runs would collide on.std::env::temp_dir()so the test respects TMPDIRVerified on aarch64/Android: client suite 31/31 green with this patch (previously 30 pass + 1 EACCES failure).