Repository navigation
Conversation
ejgallego
force-pushed
the
perf/external-highlight-build
branch
from
November 11, 2026 01:43
04320a4 to
1960810
Compare
ejgallego
changed the title
We remove a redundant call to `lake build subverso-extract-mod` when loading external code examples. The call is not needed because the subsequent `lake build +Module:highlighted` already builds the extractor as a dependency. Running both commands starts Lake twice, even when the external project is up to date. In local measurements on a small, warm project, this reduces median loader time from 993 ms to 486 ms. The regression tests cover cold and warm loads, source changes, compilation failures, and recovery on the current toolchain and Lean 4.31. `lake build` and all 858 tests pass. No-Changelog: reduce internal build overhead without changing the author-facing API.
ejgallego
force-pushed
the
perf/external-highlight-build
branch
from
November 11, 2026 02:00
1960810 to
444ae4b
Compare
ejgallego
marked this pull request as ready for review
November 11, 2026 02:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We remove a redundant call to
lake build subverso-extract-modwhen loading external code examples. The call is not needed because the subsequentlake build +Module:highlightedalready builds the extractor as a dependency. Running both commands starts Lake twice, even when the external project is up to date.In local measurements on a small, warm project, this reduces median loader time from 993 ms to 486 ms.
The regression tests cover cold and warm loads, source changes, compilation failures, and recovery on the current toolchain and Lean 4.31.
lake buildand all 858 tests pass.No-Changelog: reduce internal build overhead without changing the author-facing API.