Repository navigation
fix: catch Verso elab failures and log instead of rethrowing - #1090
Merged
Merged
Conversation
The basic block and inline elaborators now catch exceptions thrown by specific elaborators and log them, emitting an empty block or inline as appropriate. This allows elaboration to proceed. Headers, which are blocks in the surface syntax, now recover from nesting errors by picking the deepest valid nesting. More errors are presented to the user at once, and the structure of the document better matches the structure of elaboration, which improves interactivity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic block and inline elaborators now catch exceptions thrown by specific elaborators and log them, emitting an empty block or inline as appropriate. This allows elaboration to proceed. Headers, which are blocks in the surface syntax, now recover from nesting errors by picking the deepest valid nesting.
More errors are presented to the user at once, and the structure of the document better matches the structure of elaboration, which improves interactivity.
No-Changelog: elab improvement with no API change