Repository navigation
perf: faster equation generation for match with value patterns - #16465
Merged
Merged
Conversation
This PR makes generating the equations of a `match` with many value patterns faster. For a `match` with two discriminants and 64 alternatives such as `| "name", 0 => ..` followed by a catch-all, it takes 0.38s instead of 1.16s. The proof of the catch-all equation processed each test `x = v` with general purpose tactics whose cost is proportional to the number of alternatives. It now traverses all tests in one pass, using an index to find the hypothesis that refutes each case. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
leodemoura
enabled auto-merge
November 14, 2026 16:07
github-actions
Bot
added
the
toolchain-available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes generating the equations of a
matchwith many value patterns faster. For amatchwith two discriminants and 64 alternatives such as| "name", 0 => ..followed by a catch-all, it takes 0.38s instead of 1.16s.The proof of the catch-all equation processed each test
x = vwith general purpose tactics whose cost is proportional to the number of alternatives. It now traverses all tests in one pass, using an index to find the hypothesis that refutes each case.🤖 Generated with Claude Code