Repository navigation
ci(weekly-lints): fail on a missing lint report and post a notice to Zulip - #886
Draft
jessealama wants to merge 1 commit into
Draft
jessealama wants to merge 1 commit into
jessealama wants to merge 1 commit into
Conversation
jessealama
requested review from
chenson2018,
fmontesi and
kim-em
as code owners
September 8, 2026 21:38
Contributor
Author
|
This is another idea that, like other reporting PRs I've made here, might apply in the new downstream setting. For now, no need to review. I'll convert the PR into a draft. |
jessealama
marked this pull request as draft
September 29, 2026 14:51
jessealama
force-pushed
the
ci/weekly-lints-guards
branch
from
October 5, 2026 03:02
40ec1f1 to
906a6aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In anticipation of more work on the weekly Zulip report, I've taken a look at some places where report generation can crash and tried to harden the workflow against failure.
We set
continue-on-errorin.github/workflows/weekly-lints.yml, which would allow a crash in Zulip report generation to silently succeed. Append toGITHUB_OUTPUTinstead of truncating it, fail the job when the build step'soutcomeisn'tsuccess, and on any failure post a notice to the same Zulip topic linking to the run.