Repository navigation
Conversation
fmontesi
requested review from
SamuelSchlesinger,
arademaker,
chenson2018,
crei and
sorrachai
as code owners
October 30, 2026 11:37
thomaskwaring
requested changes
Nov 12, 2026
thomaskwaring
left a comment
thomaskwaring
left a comment
Collaborator
There was a problem hiding this comment.
this is cool! these are just golfs, the content looks pretty good to me
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Collaborator
Author
|
all done, @thomaskwaring! |
ctchou
pushed a commit
to ctchou/cslib
that referenced
this pull request
Nov 12, 2026
…prover#1215) Some API for fixed points which I have found useful in my own work, one result of which was needed in leanprover#1177. It's likely that if / when domain theory arrives in CSlib these kind of results will be useful here, but these could also be upstreamed to Mathlib. --------- Co-authored-by: twwar <tom.waring@unimelb.edu.au> Co-authored-by: Fabrizio Montesi <fm@fabriziomontesi.com>
thomaskwaring
requested changes
Nov 13, 2026
thomaskwaring
left a comment
thomaskwaring
left a comment
Collaborator
There was a problem hiding this comment.
most of the way there i reckon :)
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Co-authored-by: Thomas Krishna Waring <51426330+thomaskwaring@users.noreply.github.com>
Collaborator
Author
|
Thanks @thomaskwaring for more good comments! All done again. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the textbook stratification of bisimilarity, as in 'Introduction to Bisimulation and Coinduction' by Sangiorgi [2011].
I chose to use
OrderHomto formalise a single bisimulation step up to a relation. This enables usingOrdinalApproxand its greatest fixed point API, which gives us a very pleasant correspondence to what's written on paper.Depends on #1173.