Repository navigation
perf(ci): cache compiled tests - #1015
Closed
SamuelSchlesinger wants to merge 1 commit into
Closed
SamuelSchlesinger wants to merge 1 commit into
SamuelSchlesinger wants to merge 1 commit into
Conversation
Build CslibTests alongside Cslib before lean-action saves its cache so subsequent runs can reuse compiled tests. The existing strict lake test step then checks the same build outputs.
SamuelSchlesinger
marked this pull request as ready for review
October 1, 2026 15:30
SamuelSchlesinger
requested review from
arademaker,
chenson2018,
crei,
fmontesi,
kim-em and
sorrachai
as code owners
October 1, 2026 15:30
Collaborator
Author
|
CI is green! Build + tests took ~10s on the cached rerun versus ~42s on the first run of the same commit, with no test modules recompiled. The full job finished in 4m50s. @jessealama I wonder what you think of this, or if you have a better way to do it. |
Collaborator
|
This works, but is pretty hacky and is a regression in mixing the test and build reporting. I think what should be done instead is that somewhere around here in |
SamuelSchlesinger
added a commit
to SamuelSchlesinger/lean-action
that referenced
this pull request
Oct 2, 2026
This PR saves the GitHub cache after testing and linting so their build artifacts can be reused, while preserving separate build, test, and lint reporting. It retains caching after test or lint failures and skips saves on exact cache hits. Based on [Chris's suggestion](leanprover/cslib#1015 (comment)). Codex assisted with implementation and validation.
austinletson
pushed a commit
to leanprover/lean-action
that referenced
this pull request
Oct 12, 2026
This PR saves the GitHub cache after testing and linting so their build artifacts can be reused, while preserving separate build, test, and lint reporting. It retains caching after test or lint failures and skips saves on exact cache hits. Based on [Chris's suggestion](leanprover/cslib#1015 (comment)). Codex assisted with implementation and validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build
CslibTestsalongsideCslibso compiled tests are included in the CI cache and can be reused by subsequent runs.Codex assisted with the workflow change and validation.