Repository navigation
perf(ci): reuse the prepared environment for style linting - #1014
SamuelSchlesinger wants to merge 2 commits into
Conversation
Retain the pinned case-sensitivity and ignored-file actions and the executable-bit check from lint-style-action, running them before Lean restores dependencies. Run lake exe lint-style in the existing checkout to avoid deleting dependencies and repeating setup. Validated with actionlint 1.7.12, source-file checks, lake exe lint-style, and git diff --check. No Lean sources or other CI gates change.
|
For context for onlookers, I maintain a very large Lean formalization and I've got a few tricks over there to lower the CI time in GitHub actions, so I am seeing what might apply to CSLib as well. |
|
CI is green! Style checks took ~7s here versus 113s on the base commit, including the preserved file checks. The full job finished in 3m10s. |
|
@jessealama I wonder what you think of this, or if you have a better way to do it. |
|
This part of CI has been a thorn in my side for some time because of how slow it is. It should be completely removed once the autoformatter lands (and I wouldn't mind even anticipating this change). Otherwise I'm fine with any non-breaking change that is faster. |
|
@chenson2018 if you want to merge this, I think we can sync with Jesse later. |
|
I'd prefer we just go ahead and remove it entirely. Nobody will miss it in the interim. |
Co-authored-by: Jesse Alama <jessealama@users.noreply.github.com>
|
Up to you @chenson2018, feel free to merge or close it. |
|
@SamuelSchlesinger I'd rather you merge #1047 :) |
Run
lake exe lint-stylein the prepared checkout, preserving all existing checks while avoiding redundant checkout and dependency setup.Codex assisted with the workflow edit and validation.