Repository navigation
Restore shared pricer state in capped YoY coupons - #3052
Open
Kiril1Shevtsov wants to merge 1 commit into
Open
Kiril1Shevtsov wants to merge 1 commit into
Kiril1Shevtsov wants to merge 1 commit into
Conversation
|
Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3041.
The underlying rate can be cached while a shared pricer has since been initialized for another coupon. The capped/floored coupon then asks that pricer for an optionlet adjustment using the wrong coupon's fixing and other state.
Reinitialize the pricer with the underlying coupon, or with the direct coupon when there is no underlying wrapper, before computing caplet or floorlet rates. Unrestricted coupons do not perform the extra initialization.
The regression uses two known historical fixings and checks the capped/floored rates against the contractual payoff. It covers both constructors, positive and negative gearing, a nonzero spread, caps, floors, collars and an unrestricted control, with interleaved repeated calls. On the unfixed implementation a coupon capped at 3% can return 5% after another coupon is priced.
Validation on macOS arm64, AppleClang 21, Boost 1.92, C++17, Boost shared pointers, with warnings treated as errors: