Repository navigation
Conversation
Add the 2027 holidays and the December 27th holiday when Christmas falls on a weekend. Also fix the 2012, 2019 and 2021 holidays according to the government lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hong Kong calendar has no data for 2027, so the moving holidays of that year are business days on master. This adds them, from the government list (https://www.gov.hk/en/about/abouthk/holiday/2027.htm) and the HKEX circular CT/077/26 of June 1st, 2026: February 8th and 9th, April 5th, May 13th, June 9th, September 16th and October 8th.
It also fixes a few earlier dates, checked against the government lists:
Sources for the past years (archived copies of the gov.hk lists):
With the change, the calendar matches the government lists for all the years I could find (2004-2007, 2009-2016 and 2018-2027), except for the one-off holiday of September 3rd, 2015, which was announced after the list was published and is already in the calendar.
testHongKongnow checks these dates and the full 2027 list, and no longer expects May 10th, 2012 to be a holiday. It fails on master with 18 errors and passes with the change.