Repository navigation
test(vscode_payload): random AES keys and nonces - #184
Merged
isc-tdyar merged 1 commit intoNov 5, 2026
Merged
Conversation
CodeQL flags the fixed test key and nonce as hard-coded cryptographic values. Since the Dependabot roll-up (intersystems-community#180) the test helper builds keys with From instead of from_slice, and CodeQL follows those into the cipher. Every test seals and opens with the same key, so the value never mattered: the key and nonce now come from the OS once per run, and the wrong-key test draws its own and asserts it differs. getrandom 0.4 is a dev-dependency here; it was already in Cargo.lock through uuid.
isc-tdyar
approved these changes
Nov 5, 2026
isc-tdyar
left a comment
Contributor
There was a problem hiding this comment.
Approved. Random key and nonce per run; clears the CodeQL fixture alerts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two critical CodeQL alerts that the Dependabot roll-up (#180) raised. Both are "hard-coded cryptographic value", on the AES key and nonce constants in
tests/unit/test_vscode_payload.rs.Why the alerts appeared now
[7u8; 32],[3u8; 12]) have been in the test for a long time.from_slice, so the test helper switched toFrom. CodeQL followsFromfrom the constant into the cipher.The fix
getrandom0.4 is now a dev-dependency of the core crate. It was already inCargo.lockthroughuuid, so no crate is added.Checks
-D warnings, with and withouttesting, and fmt are clean.cargo denyis clean.