Skip to content

fix(ci): enforce the Java 17 SDK build contract - #51

Closed
imbajin wants to merge 49 commits into
java17-candidate-cutoverfrom
fix/java17-sdk-build-contract
Closed

imbajin wants to merge 49 commits into
java17-candidate-cutoverfrom
fix/java17-sdk-build-contract

Conversation

@imbajin

@imbajin imbajin commented Oct 5, 2026 •

Copy link
Copy Markdown

Before → after: candidate SDK setup now rejects unsupported JDKs, installs resolved Maven parent coordinates, and validates a fixed ASF source baseline. Server 1.7 compatibility tests use the official 1.7.0 binary release with its official checksum and cache provenance, instead of rebuilding an old tag. Download failures do not fall back to a source build; existing configuration, HTTP/HTTPS, authentication and consumer tests remain in place.

Reproducible Java 17 CI with fixed ASF SDK and released/candidate Server baselines

Core versions: Java 17, TinkerPop 3.8.1, and Hadoop 3.3.6. The unpublished candidate SDK continues to be built from a fixed ASF commit. A separate upstream compatibility workflow checks current ASF master without changing the reproducible baseline.

Third-party Maven caching reuses the existing Java setup cache while excluding HugeGraph SDK artifacts and manifests. Hubble’s duplicate Maven cache is removed. Build instructions and Docker commands use the repository root context. Hubble excludes the unused org.apdplat:word runtime dependency; configuration remains available and segmentation executes in Server.

HDFS uses the pinned official image. Coverage uploads stay in existing test jobs through OIDC; upload failures and coverage thresholds remain advisory. The required/advisory separation from apache#791 is preserved.

Shared SDK/archive/manifest production and expanded final-image import/query or Compose verification are tracked in apache#792 and are outside this PR. Spark and Flink runtime changes remain in apache#785 and apache#786.

Validation: prior-head CI passed candidate and release consumer tests, product images, and upstream compatibility. The latest dependency exclusion and official-release fixture changes are pushed for CI validation; no local runtime tests were run.

- reject unsupported candidate SDK build JDKs early
- validate exact Java 17 provenance in distributions
- isolate the pinned legacy Server compatibility JVM
- require the SDK generator Java version format
- reject numeric and fractional manifest versions
- preserve controlled malformed manifest diagnostics
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e8595ecb-828d-4183-bc48-6a8fa94028b9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the client label Oct 5, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T02:27:31.358760Z 3c5891b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

- inherit finalized prerequisite branch content
- preserve component-specific Java 17 changes
- reconcile upstream squash history without rewriting heads
- inherit the upstream-ready metadata guide
- remove the historical validation screenshot
- preserve module-specific code and configuration
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

- inherit the latest ASF master baseline
- preserve the Java 17 SDK build contract
- retain typed SDK manifest validation
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

- retain explicit pre-merge source TODO declarations
- inherit the coordinated ASF migration requirement
- preserve all module-specific runtime behavior
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

- inherit the latest ASF CI orchestration
- preserve the Java 17 SDK build contract
- retain typed manifest validation and release pin
- align the prerequisite review base with current ASF master
- retain candidate migration behavior unchanged
- keep dependent organization review diffs focused
- align source selection guidance with consolidated planning
- preserve the Go historical service baseline
- keep module runtime behavior unchanged
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

- inherit the SDK-aware container build prerequisites
- preserve source provenance and image startup gates
- keep module-specific behavior unchanged
- validate the canonical base behind GitHub stack merges
- retain strict freshness and failure handling
- preserve module-specific validation contracts
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

- inherit the actual merged ASF master
- preserve reviewed component behavior
- reconcile squash ancestry without rewriting branch history
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

- reuse the existing Hadoop 3.3.6 container fixture
- remove the unused Hadoop archive cache
- collect HDFS logs and remove containers after tests
- install concrete CI-friendly parent coordinates
- retain same-source reactor and isolated repository
- preserve license metadata processing and verification
- route reports using the GitHub repository identity
- ignore stale repository upload tokens
- limit OIDC permissions to coverage jobs
- expect native flatten goal before SDK installation
- retain CI-friendly version and installed POM checks
- verify the complete server fixture Node test suite
Pin the official Spark 3.5.8 Java 17 image digest.

Extract its verified runtime with Docker instead of archives.

Expose the runtime home and clean up the temporary container.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

- keep runtime preparation in its consuming job
- retain the shared HDFS container fixture
- avoid an extra CI abstraction
- build SDK and server distribution dependency closure
- avoid released Toolchain dependencies from server tests
- retain all required SDK provenance and license checks
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

imbajin added 23 commits October 7, 2026 14:38
- describe the selected Server distribution and SDK modules
- document Maven dependency closure installation
- remove the outdated complete-reactor claim
- fetch the verified ASF commit instead of moving master
- retain full source identity and artifact provenance checks
- document the fixed baseline separately from latest master
- resolve short Git selectors before transport and verification
- retain complete machine identity and SDK artifact checks
- bind packaging to the selected CI source context
- shorten configuration and user-facing baseline references
- retain the historical release tag baseline
- resolve its abbreviated expected commit through GitHub
- compare the complete resolved source identity
- resolve ASF master once for each compatibility run
- build SDK and Server from the same resolved commit
- reuse core compilation and existing unit and HTTP suites
- retain diagnostic reports without changing required gates
- separate the fixed baseline from current master testing
- document one resolved source identity per compatibility run
- reuse existing core tests without duplicate engine matrices
- select the immutable ASF baseline with six characters
- resolve the full identity before fetching Server
- remove the moving master fetch override
- warn instead of failing when Codecov upload errors
- keep upload setup failures outside test job results
- reuse the existing upload steps and authentication
Move Codecov configuration to the repository root.
Keep project and patch coverage statuses informational.
Preserve the client example exclusion relative to the root.
Separate affected consumer tests from merge requirements so maintainers can decide whether failed or cancelled advisory checks need another run.
- retain upstream advisory CI and independent scans
- preserve the locked SDK identity and reactor closure
- merge isolated parent metadata regression coverage
- reconcile HDFS cleanup and CI documentation
- retain the merged CI policy wording
- avoid early paragraph wrapping
- preserve tables and code blocks
- pin CI, SDK bootstrap and image builds to full source identities
- remove abbreviated commit API expansion from checkout and packaging
- retain verified full commit context for upstream canary validation
- show short identities in docs and read the execution lock locally
- retain archive member preflight validation
- apply the native data filter during extraction
- cover sequential links and valid internal links
- use the merged ASF request encoding fix
- align workflow and image source identities
- retain full machine locks and short documentation
- pin the ASF binary release URL and official SHA-512
- verify release identity and both archive checksums on cache reuse
- preserve Java 17 candidate builds and existing service startup
- update offline fixture contracts for release downloads and failures
- fix the official 1.7.0 source repository and commit
- reject mismatched callers before cache reads or downloads
- validate and record release source identity in manifests
- cover false source claims in offline fixture contracts
- reuse third-party Maven inputs without HugeGraph SDKs
- remove the duplicate Hubble Maven cache
- correct candidate build and Docker context instructions
keep Server configuration and Struct dependencies

leave segmentation execution in the Server process

avoid bundling the unused GPL Word dependency
- download Server 1.7 from its current ASF location
- retain the official checksum and source validation
- update the fixture identity expectation
- find the unique runnable Server in official packages
- preserve the two-instance configuration and tests
- remove macOS sidecars before graph discovery
- fall back only to the verified official archive
- keep canonical cache identity and checksum failures
- remove the unreachable short-ref rewrite
- detect tarfile extraction filter support before runtime setup
- keep safe extraction mandatory without an unfiltered fallback
- cover unsupported Python with existing archive unit tests

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c5891b425

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +400 to +402
return bool(re.search(r"(^|/)(pom\.xml|package\.json|yarn\.lock|package-lock\.json)$|"
r"(^|/)(assembly|licenses)/|(^|/)(LICENSE|NOTICE)$|dependency/|"
r"^\.mvn/|^\.github/(configs/|workflows/(license-checker|dependency-license)\.yml)", path))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include Go and Python manifests in dependency selection

For PRs that only update the existing hugegraph-client-go/go.mod or hugegraph-hubble/hubble-dist/assembly/travis/requirements.txt, this predicate returns false, so the new condition in codeql-analysis.yml skips dependency-review; before this commit that review ran on every PR. GitHub dependency review supports both Go modules and pip manifests, as documented in the supported ecosystems list, so these dependency updates now bypass the vulnerability and license review entirely.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Go manifest selection repair is posted in org #73 and ASF #820. go.mod and go.sum now select the existing dependency audit and its PR dependency-review job. The Python requirements path is already selected through its assembly location, so this follow-up changes only the missing Go inputs. Runtime selection stays Go-only and the configured CodeQL languages are unchanged. These PRs are pending merge; the older baseline still lacks the Go repair, so this thread remains open.

- remove restored Maven negative-cache markers
- retain downloaded third-party dependencies
- recheck repositories after transient failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant