Repository navigation
Conversation
RPCs without an explicit google.api.routing annotation previously extracted implicit x-goog-request-params parameters only from the first HTTP binding, omitting parameters defined in additional_bindings. Update annotateMethod and add routingParamsFromBindings in internal/sidekick/swift so fallback extraction walks all HTTP bindings in declaration order and deduplicates repeated routing keys. For googleapis/google-cloud-swift#1630
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Swift sidekick generator to extract fallback routing parameters across all google.api.http bindings in declaration order, deduplicating repeated routing keys per AIP-4222, rather than only using the first binding. It introduces routingParamsFromBindings in format_path.go and updates annotateMethod to use it. Extensive unit tests have been added to verify this behavior across various binding configurations and to ensure correct Swift stub generation. I have no additional feedback to provide as the implementation is clean and well-tested.
coryan
marked this pull request as ready for review
November 20, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPCs without an explicit google.api.routing annotation previously extracted implicit x-goog-request-params parameters only from the first HTTP binding, omitting parameters defined in additional_bindings.
Update annotateMethod and add routingParamsFromBindings in internal/sidekick/swift so fallback extraction walks all HTTP bindings in declaration order and deduplicates repeated routing keys.
For googleapis/google-cloud-swift#1630
Draft changes: googleapis/google-cloud-swift#1675 (no changes, the bug is not triggered by any of the current libraries)