Skip to content

cleanup(internal/sidekick/rust): remove extend_grpc_transport option - #7962

Merged
dbolduc merged 2 commits into
googleapis:mainfrom
dbolduc:cleanup/rust-extend-grpc-transport
Nov 19, 2026
Merged

dbolduc merged 2 commits into
googleapis:mainfrom
dbolduc:cleanup/rust-extend-grpc-transport

Conversation

@dbolduc

@dbolduc dbolduc commented Nov 19, 2026

Copy link
Copy Markdown
Member

Unconditionally make the transport stub pub(crate) in gRPC-based crates so it can be extended in veneers.

Make the inner gRPC client field in the grpc-client transport template
unconditionally visible within the generated crate and remove the
extend_grpc_transport module configuration option along with its corresponding
extend-grpc-transport codec flag.

Generated grpc-client transport modules are already internal to the crate, so
restricting the inner gRPC client field to private visibility unless an opt-in
flag was set added unnecessary configuration overhead for veneer crates that
extend generated transports.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the extend_grpc_transport configuration option and all of its associated implementation, tests, and documentation across the codebase. Consequently, the inner field of the generated Rust gRPC client transport struct is now always defined with pub(crate) visibility. I have no additional feedback to provide as there are no review comments.

@dbolduc
dbolduc marked this pull request as ready for review November 19, 2026 22:46
@dbolduc
dbolduc requested review from a team as code owners November 19, 2026 22:46
@dbolduc dbolduc changed the title refactor(internal/sidekick/rust): remove extend_grpc_transport option cleanup(internal/sidekick/rust): remove extend_grpc_transport option Nov 19, 2026
Signed-off-by: Darren Bolduc <dbolduc@google.com>
@dbolduc
dbolduc enabled auto-merge (squash) November 19, 2026 23:35
@dbolduc
dbolduc merged commit 3f3ab30 into googleapis:main Nov 19, 2026
47 checks passed
@dbolduc
dbolduc deleted the cleanup/rust-extend-grpc-transport branch November 19, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants