Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sjperkins
force-pushed
the
single-copy-cord-to-python
branch
from
November 2, 2026 13:42
282a277 to
7452a11
Compare
CordToPython built `py::bytes(std::string(cord))`, which flattens the cord into a temporary string and then copies that into the bytes object. Use BytesFromCord instead, which copies the cord's chunks straight into a new bytes object.
sjperkins
force-pushed
the
single-copy-cord-to-python
branch
from
November 2, 2026 13:54
7452a11 to
0490eab
Compare
Contributor
Author
|
Thanks for including this change. Could you please provide a pypi release with the above fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReadResult.valueandKvStore.__getitem__convert theabsl::Cordthrough a temporarystd::string. That copies the payload twice. This PR reusesBytesFromCordfromserialization.cc, which copies the cord's chunks straight into a newbytesobject.py::bytes CordToPython(const absl::Cord& value) { - return py::bytes(std::string(value)); + auto obj = BytesFromCord(value); + if (!obj) throw py::error_already_set(); + return py::reinterpret_steal<py::bytes>(obj.release()); }py::byteshas no constructor that takes over astd::string. Even if it had one, aPyBytesObjectkeeps its data inline, so the second copy can't be avoided by moving.Evidence
Both builds use
-c opt --copt=-O3, CPython 3.14 (with the GIL) on 12-core x86-64 Linux. A local HTTP server serves 15.5 MB objects.ReadResult.value, median per 15.5 MB object.valuecalls.valueon each.valueThe speed-up is bigger than removing one copy alone would give. The temporary string and the
bytesobject were each mapped fresh on every call, costing about 7,900 page faults per 15.5 MB, and this PR avoids most of those.python/tensorstore/tests/kvstore_test.py: 16 passed.Merge Danger
Door: two-way
Blast Radius:
KvStore.__getitem__andReadResult.value. Both still return the samebytes.🤖 Generated with Claude Code