Skip to content

cmd/present: disable rich-text formatting - #705

Open
jub0bs wants to merge 1 commit into
golang:masterfrom
jub0bs:fix-issue-82769
Open

jub0bs wants to merge 1 commit into
golang:masterfrom
jub0bs:fix-issue-82769

Conversation

@jub0bs

@jub0bs jub0bs commented Nov 2, 2026 •

Copy link
Copy Markdown

Pasting HTML content into a code snippet retains its formatting, which
is undesirable.

This CL changes the value of the contenteditable attribute from "true"
to "plaintext-only" to disable rich text formatting in code snippets.
To avoid spurious blank lines above and below code snippets, this CL
removes some line breaks (which are interpreted literally with
"plaintext-only") from the relevant templates.

Fixes golang/go#82769

@jub0bs
jub0bs force-pushed the fix-issue-82769 branch 2 times, most recently from eb5cdce to 7621cd4 Compare November 2, 2026 14:13
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 7621cd4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/857581.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/857581.
After addressing review feedback, remember to publish your drafts!

Pasting HTML content into a code snippet retains its formatting, which
is undesirable.

This CL changes the value of the contenteditable attribute from "true"
to "plaintext-only" to disable rich text formatting in code snippets.
To avoid spurious blank lines above and below code snippets, this CL
removes some line breaks (which are interpreted literally with
"plaintext-only") from the relevant templates.

Fixes golang/go#82769
@jub0bs jub0bs changed the title {,cmd/}present: disable rich-text formatting cmd/present: disable rich-text formatting Nov 2, 2026
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 3046fd2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/857581.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from jub0bs:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/857581.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/tools/present: rich text formatting in editable code snippets should be disabled

2 participants