[monta990]

Checklist before requesting a review

Please delete options that are not relevant.

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

• in relationship Used Items & Managed items count badge in user menu roadmap#202
• Continues closed PR Feature: Used and managed items user count #24318 with the suggestions applied (focused on main (glpi 12))
• New icon for managed items

Screenshots (if appropriate):

[AdrienClairembault]

This variable is build from a SQL query but is never used.

[monta990]

You're right. The $groups array is no longer used after the refactoring.

The issue was introduced when I extracted the common group criteria logic into getItemsForUserCriteria(). The original showItems() code populated $groups from the group query, but after the refactoring the display logic relies on $group_choices instead. This left the $groups array and its associated query unused.

I'll remove $groups and $groups_iterator from showItems(). The groups_ids query in getItemsForUserCriteria() will remain, since those IDs are still required to build the user/group criteria.

[monta990]

Thanks for pointing this out. I checked the current version of showItems() again: the result from $groups_iterator is consumed immediately by the foreach to populate $groups.

So, in the current commit, the SQL result is actually used. I believe this comment may refer to an earlier state of the diff before the subsequent commits updated this section.

[AdrienClairembault]

Thanks for pointing this out. I checked the current version of showItems() again: the result from $groups_iterator is consumed immediately by the foreach to populate $groups.

So, in the current commit, the SQL result is actually used. I believe this comment may refer to an earlier state of the diff before the subsequent commits updated this section.

Can you please clarify how the content of $group is used after bien populated?

[monta990]

You're right. The $groups array is no longer used after the refactoring.

The issue was introduced when I extracted the common group criteria logic into getItemsForUserCriteria(). The original showItems() code populated $groups from the group query, but after the refactoring the display logic relies on $group_choices instead.

I'll remove $groups and $groups_iterator from showItems(). The groups_ids query in getItemsForUserCriteria() will remain, since those IDs are still required to build the user/group criteria.

[cedric-anne]

Tests are failing.

[monta990]

fix for COUNT DISTINCT in select

[monta990]

Tests are failing.

Thanks for pointing this out. I corrected the query by moving COUNT DISTINCT under the SELECT key, which resolved the SQL errors.

The latest CI run is now passing, including the PHP 8.3/MySQL and PHP 8.5/MariaDB test suites, lint checks, Playwright tests, and the security scan.

Thanks again for the feedback and for helping improve this PR.

Working in GLPI 12

[cedric-anne]

IA;DR

Tests were fixed.