Repository navigation
Batch of Striker Ball Updates to Bones - #524
Merged
Merged
Conversation
Maintains the rollback & reset compatibility. Deprecates the `add_startup_system` method.
…and into wrapper system implementation on SessionBuilder.
…nto SessionBuilder. Removes the need for the SystemStages in World reset implementations.
Remove implied and/or distracting comment.
…` & add that method `World` level.
…le success systems to use Ulids & deprecate `add_single_success_system` in favor of stable usage for now
Changes ResetWorld functionality to reset resources by retention instead of "post replacement".
Moves Session system methods to SystemStages since Session derefs to its stages. Remove SessionBuilder & SystemStagesBuilder in favor of simplification and a more open capability. The limitations set by these builders were not fullproof and making them so sacrifices too much. A more limiting / safe layer likely belongs at the higher level and can be decided on better after more games have been made.
It is possible it could have use in the future but is unlikely. Simplicity is more important and we can still add this if needed later.
…ublicizes the GILRS_CONTEXT. This removes the default implementation from the gamepad events and thus adds the no_default attribute to their schema. This changes how the events can be used in scripts but it is largely expected that you won't handle that level of inputs in scripts.
…events in favor of simpler method of obtaining gilrs::Gamepad data. Instead of giving the gilrs::GamepadId directly and therefore disallowing arbitrary ids which can be useful for testing and more, the gilrs::Gamepad data can technically still be obtained optionally with an arbitrary id with Gilrs::gamepads.
…n't related to this type itself.
…:Startup` and is now the stage used in `add_startup_resource` and `init_startup_resource`.
Fixes a determinism problem in the tests with generating Ulids. Uses a static number in the background incremented with each call to the wrapper function. This means you can no longer keep track of custom specified systems of this kind, but if the case requires it you should be using a different system. I also removed the helper systems on the SingleSuccessSystems resource since users won't need them. As a user you can still reset all systems though by removing the resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains a batch of updates by @TekhnaeRaav that were used in Striker Ball.