Skip to content

Development - #885

Open
SebKrantz wants to merge 9 commits into
masterfrom
development
Open

SebKrantz wants to merge 9 commits into
masterfrom
development

Conversation

@SebKrantz

Copy link
Copy Markdown
Member

No description provided.

arthurgailes and others added 9 commits September 23, 2026 16:05
Copy the collapse-r skill from fastverse/skills (c3748aa) into
inst/skills/ so btw discovers it when collapse is attached and
btw_skill_install_package("collapse") can install it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: Sebastian Krantz <48053842+SebKrantz@users.noreply.github.com>
Fix na_omit()/missing_cases() on single-row matrix with cols (#886)
Co-authored-by: Sebastian Krantz <48053842+SebKrantz@users.noreply.github.com>

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Fix fmedian weighted result depending on weight scale (#883)
@SebKrantz

Copy link
Copy Markdown
Member Author

@claude please debug this and fix with a PR to development.

@claude

claude Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Claude finished @SebKrantz's task in 38s —— View job


Diagnosis done, but I couldn't push the fix

  • Found the failing CI check (test-coverage)
  • Found the cause
  • Fixed it locally
  • Push and open a PR to development: blocked

Cause: the one failure is in the new test, not in the C fix for #883.

Failure ('test-fmedian.R:702:3'): fmedian with weights is invariant to weight scaling (#883)
Expected `fmedian(x, w = w * 1000, g = rep(1L, 6))` to equal 35.
names for target but not for current

A grouped call returns a named result by default (use.g.names = TRUE). The test compared it to an unnamed 35. The numeric values match, and the other 22,877 tests pass.

Fix: add use.g.names = FALSE to that call at tests/testthat/test-fmedian.R:702. The earlier test at lines 690–691 already does this.

expect_equal(fmedian(x, w = w * 1000, g = rep(1L, 6), use.g.names = FALSE), 35)

Why it isn't pushed:

  • Pushing to development was rejected because the branch is protected.
  • My attempt to create a new branch was blocked by a permission prompt, so there is no branch or PR yet.
  • The fix is committed locally in the runner only.
  • I haven't run the tests. The fix is based on the CI log.

You can apply the one-line change above directly. Or allow git checkout -b in my allowed tools and re-trigger me, and I'll push a branch and open the PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants