Skip to content

fix: harden document analysis and Verso navigation - #1

Open
ejgallego wants to merge 1 commit into
mainfrom
fix/document-analysis-boundaries
Open

ejgallego wants to merge 1 commit into
mainfrom
fix/document-analysis-boundaries

Conversation

@ejgallego

Copy link
Copy Markdown
Owner

Saved analysis now uses the same strict semantic-span contract as live decoding, and session-fatal errors propagate through analysis. The writer exclusively owns stdin, cleanup reports each worker’s final state, and workspace helpers preserve open overlays with scoped document cleanup.

The Manual bridge delegates occurrence IDs and definition URLs to Verso, so repeated inclusions and cross-page links work. Logical request keys use collision-free pairs, requests compile through quotation, and the renderer converts overlay coordinates once. Bundle revision 2 removes duplicated authored diagnostic locations and adds caller-owned context provenance. Regenerate saved bundles; migration instructions describe the API changes and exact-request replay limits.

Validation: core tests on Lean 4.35.0 and 4.36.0-rc2; bridge tests and fresh Git-consumer isolation. VBP integration acceptance covers Rust/Rocq, offline HTML/TeX, repeated inclusions, multi-page navigation, nested-page hovers, and unchanged Blueprint queries. Five repeated analyses completed all fifteen session cleanups. The earlier intermittent cleanup failure’s exact cause was not reproduced; EOF ownership and stale completion sampling have explicit fixes, and cleanup failures remain strict.

Used by leanprover/verso-blueprint#502.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant