Skip to content

Fix dump of macosx console logging in the launcher in case of DEBUG mode - #1392

Open
GaborLajos wants to merge 2 commits into
eclipse-equinox:masterfrom
GaborLajos:corr_fgConsoleLogDump
Open

GaborLajos wants to merge 2 commits into
eclipse-equinox:masterfrom
GaborLajos:corr_fgConsoleLogDump

Conversation

@GaborLajos

Copy link
Copy Markdown
Contributor

This change fixes /dev/console logging in the macOS Cocoa launcher.

The prior implementation used a shared global log handle and initialized it by fopen( ). In cases where the console log could not be opened (e.g.: due to Operation not permitted), the log file was uninitialized and resulted dump in DEBUG=1 mode. This patch:

  • makes the log stream explicit by passing a FILE* into the debug and argument-dump helpers,
  • opens /dev/console at startup and keeps a local handle for the process lifetime,
  • falls back to stderr if the console log cannot be opened,
  • closes the log file correctly,
  • keeps the existing debug output behaviour intact.

@merks

merks commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

I suggest squashing to a single commit with a nice summary and force pushing that.

@GaborLajos
GaborLajos force-pushed the corr_fgConsoleLogDump branch from 94a1997 to 1210aef Compare November 2, 2026 12:26
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Test Results

  234 files  ±0    234 suites  ±0   46m 50s ⏱️ - 1m 19s
2 231 tests ±0  2 182 ✅ ±0   49 💤 ±0  0 ❌ ±0 
6 456 runs  ±0  6 343 ✅ ±0  113 💤 ±0  0 ❌ ±0 

Results for commit 3b5f52d. ± Comparison against base commit 8ed55e9.

♻️ This comment has been updated with latest results.

@GaborLajos
GaborLajos force-pushed the corr_fgConsoleLogDump branch 2 times, most recently from 3028d66 to af35384 Compare November 5, 2026 16:19
@GaborLajos
GaborLajos force-pushed the corr_fgConsoleLogDump branch from af35384 to 2daa29e Compare November 6, 2026 19:17

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants