Repository navigation
Conversation
Contributor
✅ Release notes checked
|
DedSec256
force-pushed
the
ber.a/fixDependenciesCache
branch
from
November 4, 2026 21:47
928454a to
d09b035
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DependencyGraphcache of the TransparentCompiler never found a cached graph: every request built the graph again, even for the same files at the same versions.The cache key, built by
Extensions.KeyinTransparentCompiler.fs, was a tuple of the graph type and the MD5 hash of the file names as abyte[].LruCachekeeps its keys in aDictionarywith the default .NET comparer. For a tuple, that comparer compares an array by reference, andGetKey()creates a new array on every call, so no two keys were ever equal. As a result:FileContentMapping.mkFileContentandDependencyResolution.mkGraphover every file in the set. For example, semantic classification or find references on a file that was just checked rebuilt the graph that the check had built;This PR keeps the hash in the key as a string, which the default comparer compares by value. The version of the key was already a string.
The new test
Dependency graph of the same files is taken from the cachechecks a file, requests its semantic classification and asserts that the graph is only requested, not built again. Without the fix it gets[Requested; Started; Finished].