`start-vs-VisualFSharpSln.ps1`: build against a locally built hive Roslyn from its own packages by xperiandri · Pull Request #20528 · dotnet/fsharp

xperiandri · 2026-09-11T17:09:47Z

Description

When the Roslyn deployed in the hive is a local build (a -dev version), the launcher now always overrides the flowed Roslyn packages and adds that checkout's Shipping and NonShipping package folders as restore sources, so F5 builds against the Roslyn it runs.

-RoslynRepo names the checkout (default: a sibling roslyn folder). The launch stops with a clear message when the checkout has no package for that version, or when the global packages folder still holds an earlier pack of it.

Shipped Roslyn versions behave as before.

-InstalledVersions takes the versions from the installed VS instead: Roslyn even when the hive has one of its own, and the System.* and MSBuild packages VS binds to its own copies, wherever the repo flows newer ones. An explicit -RoslynVersion still wins for Roslyn.

Tooling only; no compiler or IDE code path changes, so no release notes entry.

Checklist

Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated

🤖 Generated with Claude Code

github-actions · 2026-09-11T17:10:01Z

✅ Release-note check exempted

The NO_RELEASE_NOTES label or localization-bot authorship exempts this pull request.

T-Gro

🤖 🕵️ AI review — verify independently.

github-actions · 2026-09-27T23:39:22Z

🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Design-Time, Affects-Restore
Affects-Build-Infra: Changes generated MSBuild configuration.
Affects-Design-Time: Changes Visual Studio launch behavior.
Affects-Restore: Changes package restore sources.

Generated by PR Tooling Safety Check · gpt56 1.7M · ◷

Copilot

Copilot review overview

🟡 Changes recommended

A missing package folder can break restore, and clearing the shared NuGet cache can disrupt other builds.

Review effort: Balanced
Findings: 1 · 1

Open (2)

Use an isolated NuGet cache for dev Roslyn builds · New
Avoid adding nonexistent Roslyn package sources · New

What changed in this PR

This PR lets the Visual Studio launch script build the F# extension against a locally built Roslyn deployed in the target hive, using that Roslyn build’s own packages.

Changes:

Override flowed Roslyn packages whenever the hive uses a -dev build.
Add the local Roslyn package folders as restore sources and clear cached copies before restoring.

File	Description
`start-vs-VisualFSharpSln.ps1`	Locates local Roslyn packages and configures the override, restore, and launch.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

T-Gro

🤖 🕵️ Re-reviewed all recent changes as of c820c98; LGTM

T-Gro

🤖 🕵️ Re-reviewed all recent changes as of 4a165d7; LGTM

T-Gro

🤖 🕵️ Re-reviewed all recent changes as of f0f219e; LGTM

T-Gro

The diff is still way too big - apply the NoBloat instructions and CodeCompaction skill.

Especially the massive code comments would benefit not just with drastic reduction, but ideally with well named functions/arguments/bindings/types making the intention clear.

If a well named piece of code just tells what the comment says - delete the comment.

This diff adds 18 new code comment lines and 1541 new code comment chars.
Comments become stale maintenance state. Keep only durable user-facing contracts; express script intent through names, functions, parameters, and validated data structures.

…est head Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

xperiandri · 2026-10-29T20:44:04Z

Started again from main's script: +38/−8 (was +72/−16), with 3 new comment lines / 196 characters (was 18 / 1541). Intent now lives in the names Get-RoslynDevFeeds, Get-StalePackageFolders and ConvertTo-PropsPath.

Covered with 30 -DryRun cases on PowerShell 7 and Windows PowerShell 5.1, and with real NuGet restores against repository names containing %20, %41, $(...), @(...), &, [1], ' and parentheses.

…est head Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

T-Gro

🤖 🕵️ Re-reviewed all recent changes as of 1a955d1; LGTM

A Roslyn built locally and deployed into the hive is there because its API surface differs from the flowed package: it is where an ExternalAccess contract lives before it flows. Matching the minor the repo flows therefore says nothing about whether the flowed packages will do, and refusing the dev version left no way to build against the Roslyn F5 actually runs. A dev version now always overrides, and the override adds the package folders of that Roslyn build to RestoreAdditionalProjectSources, since no feed carries its version. -RoslynRepo names the repository, next to this one by default, and the script checks that it actually holds the package before restore fails halfway with NU1101. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

…d drop stale -dev packages Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Start again from main's script and add only what the feature needs: the nested restructure and the -LiteralPath edits on lines the script already had are gone, and the added comments drop from 18 lines to 3. A repack that keeps the same -dev version is detected by comparing the restored nupkg with the feed's, and the launch stops with the folders to delete instead of deleting them under whatever still reads the cache. Feed paths are MSBuild-escaped before the XML escape, so %20, %41, $(...) and @(...) in a repository path reach NuGet unchanged. The -RoslynRepo default is resolved in the function body, because $PSScriptRoot is empty in a param() default under Windows PowerShell 5.1 when [CmdletBinding()] is present, and the parameter comes last so the existing positional parameters keep their positions. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

A Roslyn deployed in the hive always won over the installed VS's, so a stale or locally built one could not be bypassed. With the switch the hive is skipped and the version comes from the installed VS's Microsoft.CodeAnalysis.dll; an explicit -RoslynVersion still takes precedence. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

The switch took only the Roslyn version from the installed VS. A hive deploy still failed when the repo flowed newer System.* or MSBuild packages than VS binds to, because VS loads its own copies of them. With -InstalledVersions the launcher also pins those libraries to the installed VS: System.Collections.Immutable, System.Composition, System.Diagnostics.DiagnosticSource and System.Reflection.Metadata from the bindingRedirects in devenv.exe.config, Microsoft.Build, .Framework, .Tasks.Core and .Utilities.Core from the version of the MSBuild it ships. A library the repo does not flow newer is left alone, and an explicit -RoslynVersion still wins for Roslyn. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

T-Gro

🤖🕵️ AI review — verify independently.

T-Gro · 2026-11-05T09:31:27Z

+        $assembly = $libraries[$property]
+        $redirect = if ($config) { $config.SelectSingleNode("//*[local-name()='dependentAssembly'][*[local-name()='assemblyIdentity' and @name='$assembly']]/*[local-name()='bindingRedirect']") }
+        $dll = Join-Path $msbuild "$assembly.dll"
+        $installed = if ($redirect) { $v = [version]$redirect.GetAttribute('newVersion'); '{0}.{1}.{2}' -f $v.Major, $v.Minor, $v.Revision }


🤖🕵️ [P2] MSBuild pinned to 15.1.0 instead of the installed package version when its assembly redirect is present. Use the MSBuild DLL's ProductVersion even when a redirect exists.

 <dependentAssembly> <assemblyIdentity name="Microsoft.Build" /> <bindingRedirect oldVersion="0.0.0.0-15.1.0.0" newVersion="15.1.0.0" /> </dependentAssembly>

.\start-vs-VisualFSharpSln.ps1 -InstalledVersions -DryRun # MicrosoftBuild 15.1.0; expected 18.0.2

xperiandri requested a review from a team as a code owner September 11, 2026 17:09

github-project-automation Bot added this to F# Compiler and Tooling Sep 11, 2026

github-project-automation Bot moved this to New in F# Compiler and Tooling Sep 11, 2026

github-actions Bot added ⚠️ Affects-Build-Infra Tooling check: PR touches build infrastructure ⚠️ Affects-Restore Tooling check: PR touches NuGet packages or feeds labels Sep 11, 2026

This comment has been minimized.

Sign in to view

T-Gro reviewed Sep 14, 2026

View reviewed changes

Comment thread start-vs-VisualFSharpSln.ps1 Resolved

Comment thread start-vs-VisualFSharpSln.ps1 Resolved

Comment thread start-vs-VisualFSharpSln.ps1 Resolved

Comment thread start-vs-VisualFSharpSln.ps1 Resolved

T-Gro added the AI-reviewed PR reviewed by AI review council label Sep 14, 2026

T-Gro self-requested a review September 14, 2026 14:28

This comment has been minimized.

Sign in to view

github-actions Bot added the ⚠️ Affects-Design-Time Tooling check: PR touches type providers or dependency manager label Sep 24, 2026

This comment has been minimized.

Sign in to view

Copilot AI balanced review requested due to automatic review settings September 29, 2026 16:56

Copilot started reviewing on behalf of xperiandri September 29, 2026 16:57

View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Comment thread start-vs-VisualFSharpSln.ps1 Resolved

Comment thread start-vs-VisualFSharpSln.ps1 Resolved

xperiandri force-pushed the start-vs-local-roslyn-packages branch from 84f3cdc to c820c98 Compare October 2, 2026 16:03

T-Gro reviewed Oct 3, 2026

View reviewed changes

xperiandri force-pushed the start-vs-local-roslyn-packages branch from c820c98 to 4a165d7 Compare October 8, 2026 01:11

T-Gro reviewed Oct 8, 2026

View reviewed changes

xperiandri force-pushed the start-vs-local-roslyn-packages branch from 4a165d7 to f0f219e Compare October 10, 2026 22:28

T-Gro reviewed Oct 13, 2026

View reviewed changes

T-Gro requested changes Oct 13, 2026

View reviewed changes

github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Oct 13, 2026

T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Oct 14, 2026

T-Gro reviewed Oct 17, 2026

View reviewed changes

Comment thread start-vs-VisualFSharpSln.ps1 Resolved

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Oct 19, 2026

Bring start-vs-VisualFSharpSln.ps1 (dotnet#20528) up to its pull requ…

0f3f1b6

…est head Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Oct 19, 2026

Bring start-vs-VisualFSharpSln.ps1 (dotnet#20528) up to its pull requ…

7320d91

…est head Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Oct 23, 2026

Bring start-vs-VisualFSharpSln.ps1 (dotnet#20528) up to its pull requ…

2fd5d8f

…est head Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Oct 23, 2026

Bring start-vs-VisualFSharpSln.ps1 (dotnet#20528) up to its pull requ…

d76dffc

…est head Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

xperiandri force-pushed the start-vs-local-roslyn-packages branch from f0f219e to c9632eb Compare October 29, 2026 19:43

xperiandri requested a review from T-Gro October 29, 2026 19:44

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Oct 29, 2026

Bring start-vs-VisualFSharpSln.ps1 (dotnet#20528) up to its pull requ…

5016f6c

…est head Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

T-Gro reviewed Nov 2, 2026

View reviewed changes

xperiandri requested a review from T-Gro November 2, 2026 12:23

xperiandri and others added 6 commits November 4, 2026 02:18

Take -RoslynRepo literally and absolutely, escape it in the props, an…

1605ac9

…d drop stale -dev packages Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Add only the Roslyn package folders that exist as restore sources

ba2e927

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

xperiandri force-pushed the start-vs-local-roslyn-packages branch from 1a955d1 to cefbe23 Compare November 5, 2026 00:24

T-Gro reviewed Nov 5, 2026

View reviewed changes

Conversation

xperiandri commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

github-actions Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Release-note check exempted

Uh oh!

This comment has been minimized.

This comment has been minimized.

T-Gro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented Sep 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

T-Gro left a comment

Choose a reason for hiding this comment

Uh oh!

T-Gro left a comment

Choose a reason for hiding this comment

Uh oh!

T-Gro left a comment

Choose a reason for hiding this comment

Uh oh!

T-Gro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xperiandri commented Oct 29, 2026

Uh oh!

T-Gro left a comment

Choose a reason for hiding this comment

Uh oh!

T-Gro left a comment

Choose a reason for hiding this comment

Uh oh!

T-Gro Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xperiandri commented Sep 11, 2026 •

edited

Loading

github-actions Bot commented Sep 11, 2026 •

edited

Loading