Repository navigation
fix: drop the internal UT-2026-0115 su pseudo-terminal patch - #27
Merged
deepin-ci-robot merged 1 commit intoOct 21, 2026
Merged
Conversation
The patch forced interactively started su to allocate its own pseudo-terminal by default. That is not upstream behavior: upstream util-linux only creates a private pty when -P/--pty is given explicitly, and runuser keeps its historical behavior. Remove the patch and its series entry so su returns to the upstream default. -P/--pty is still available for callers that want the private pseudo-terminal, and kernels >= 6.2 keep TIOCSTI disabled by default. No other patches depend on this one; the remaining series still applies cleanly. Log: Removed the internal UT-2026-0115 su patch, restoring upstream su terminal behavior Influence: 1. Verify su works interactively without a private pty by default 2. Verify su -P/--pty still creates a private pseudo-terminal 3. Verify runuser behavior is unchanged 4. Verify the package builds with the reduced patch series fix: 移除内部 UT-2026-0115 su 伪终端补丁 该补丁让交互式启动的 su 默认分配自己的伪终端。这不是上游行为： 上游 util-linux 只在显式指定 -P/--pty 时才创建私有 pty， runuser 保持原有行为。 移除该补丁及 series 条目，使 su 回到上游默认行为。 需要私有伪终端的调用方仍可使用 -P/--pty， 且 6.2 及以上内核默认禁用 TIOCSTI。 没有其他补丁依赖此补丁，剩余 series 仍可干净应用。 Log: 移除内部 UT-2026-0115 su 补丁，恢复上游 su 终端行为 Influence: 1. 验证 su 交互式登录默认不再使用私有 pty 2. 验证 su -P/--pty 仍能创建私有伪终端 3. 验证 runuser 行为未发生变化 4. 验证裁剪补丁后的包可以正常构建 repo: util-linux #master
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe package revision is bumped to 2.40.4-3deepin17 while removing the internal su TIOCSTI/TIOCLINUX pseudo-terminal patch, restoring upstream shared-terminal behavior unless su is invoked with --pty; the remaining patch stack is unchanged and verified to apply cleanly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
TAG Bot TAG: 2.40.4-3deepin17 |
Contributor
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Zeno-sole The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/lgtm |
Contributor
|
@Zeno-sole: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the internal
UT-2026-0115-su-tiocsti.patchthat was added by #22 (2.40.4-3deepin13) and bump the package to2.40.4-3deepin17.What changes
debian/patches/UT-2026-0115-su-tiocsti.patchand itsdebian/patches/seriesentry.pipesz-test-skip-nonroot.patchstays).With the patch gone, su is back to the upstream util-linux behavior: an interactive su shares the caller's controlling terminal unless
-P/--ptyis given explicitly. runuser was never affected.-P/--ptyremains available for callers that want the private pseudo-terminal.Impact
dev.tty.legacy_tiocstiis the only way to re-enable it); on older kernels or with the legacy knob enabled, the shared-terminal injection window returns for su users who do not pass-P/--pty.quilt push -a, no fuzz/offset on files touched by this patch).Verification
quilt push -aon a cleangit archiveof master with the modified series: all patches applied, no failures.debian/changelog,debian/patches/series, and the deleted patch file.Fixes: refs #22
Summary by Sourcery
Restore upstream su terminal behavior by dropping the internal TIOCSTI hardening patch and update the package revision.
Bug Fixes:
Chores: