Skip to content

fix(mosaic): center the pending spinner on an OrganizationList row - #10607

Merged
alexcarpenter merged 1 commit into
mainfrom
carp/mosaic-item-loading
Nov 3, 2026
Merged

alexcarpenter merged 1 commit into
mainfrom
carp/mosaic-item-loading

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Description

The pending spinner on an OrganizationList row sat in Item.Actions, which has no width of its own, so it was pressed against the row's edge. It now sits in Item.Media, giving it a 40px trailing column that mirrors the avatar: both centers are 27px from their edge of the row.

Item.Media's doc comment drops "leading" since it now appears on both sides. The load-more row in the same view already used Item.Media for its spinner.

Before After
Pending spinner pressed against the row edge Pending spinner centered in a trailing column

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Nov 3, 2026 2:45pm UTC
swingset Ready Ready Preview Nov 3, 2026 2:45pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1637c31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/mosaic Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

SelectRow now renders its pending spinner in Item.Media instead of Item.Actions. The spinner’s size and label remain unchanged. The Item.Media description now includes a spinner example, and a patch changeset documents the placement.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

  • clerk/javascript#10502: Adds the OrganizationList component and the row code updated here.
  • clerk/javascript#10591: Extracts organization-list row rendering from the view that this change updates.
  • clerk/javascript#10600: Changes Item.Media width and avatar sizing, which affect the row column geometry relevant to spinner alignment.

Suggested reviewers: kylemac, ephem

Merge Risk: Minimal · up to 1637c

The localized spinner placement change is ready to merge.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: centering the pending spinner on an OrganizationList row.
Description check Passed The description directly explains the spinner positioning bug, the implementation change, and the related documentation update.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between d22c84b and 1637c31.

Files selected for processing: 3
  • .changeset/mosaic-org-list-pending-spinner.md
  • packages/mosaic/src/components/item/item.tsx
  • packages/mosaic/src/features/organization-list/organization-list.view.tsx
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

@pkg-pr-new

pkg-pr-new Bot commented Nov 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10607

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10607

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10607

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10607

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10607

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10607

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10607

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10607

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10607

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10607

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10607

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10607

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10607

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10607

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10607

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10607

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10607

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10607

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10607

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10607

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10607

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10607

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10607

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10607

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10607

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10607

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10607

commit: 1637c31

@alexcarpenter
alexcarpenter merged commit 481d97a into main Nov 3, 2026
56 checks passed
@alexcarpenter
alexcarpenter deleted the carp/mosaic-item-loading branch November 3, 2026 18:41

This branch was successfully deployed

2 active deployments
Preview – swingset — 1637c313 Deployed Nov 3, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 1637c313 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants