Repository navigation
fix(ui,localizations,shared): Show a pull directory without credentials as In Progress - #10569
Draft
mauricioabreu wants to merge 1 commit into
Draft
mauricioabreu wants to merge 1 commit into
mauricioabreu wants to merge 1 commit into
Conversation
…ls as In Progress A Google Workspace directory exists in the Security tab as soon as the wizard opens, before its credentials are stored. The section read `enabled` only, so the row said Inactive and offered Activate, which the server refuses. Derive an In Progress status from `credentialsConfigured`, offer Continue configuration instead of Activate, and stop the wizard stepper ticking the configure step early.
🦋 Changeset detectedLatest commit: 27a4a95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A Google Workspace directory shows up in the
<OrganizationProfile />Security tab the moment the Directory Sync wizard opens, before its service account credentials are stored. The section derived its badge fromenabledalone, so that half-configured directory read Inactive and offered Activate. The server refuses that activation until the credentials exist, and the refusal is a field-scoped error the section drops, so the admin saw a dead switch. One admin read it as a Clerk-side gate.The section now treats
credentialsConfigured === falseas an In Progress status that outranksenabled, the way the SSO section above it and the Dashboard already do. In that state the row shows an In Progress badge, a Continue configuration button that reopens the wizard at the credentials step, and a menu with Edit and Remove only. The wizard stepper also stops ticking the configure step before the credentials exist. Push providers are unaffected, since the field isnullfor them.To test: open the Security tab of an organization with a Google Workspace SSO connection, click Configure, and leave the wizard without uploading a key. The section should read In Progress with Continue configuration instead of Inactive with Activate.
Backend side, which makes the server's refusal visible even on older
@clerk/ui: clerk/clerk_go#23651. Docs: clerk/clerk#3749.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change