Repository navigation
Move per-PR macOS CI to nightly; update action versions - #763
Merged
Merged
Conversation
Signed-off-by: Kyle Mandli <kyle.mandli@gmail.com> Assisted-by: claude opus-5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables the testing on macOS to only every night to reduce action costs. Also updates versions of some actions and puts some additional guardrails on the CI.
Brings this repo's CI in line with GeoClaw (clawpack/geoclaw
b432880d), where macOS was moved off the per-PR path because macOS runners bill at 10x the Linux minute rate.Per-PR (
testing.yml)ubuntu-latest, gcc 14, debug + opt. The gcc 15 toolchain and the os/toolchainexclude:block are removed.concurrencywithcancel-in-progressso new pushes to a PR cancel the superseded run.paths-ignorefor**.md,**.rst,docs/**,.gitignore(same list as GeoClaw).timeout-minutes: 30(recent runs take 3–8 min).Nightly (
nightly.yml, new)schedule(07:30 UTC, staggered after GeoClaw's 06:00) +workflow_dispatch.macos-latest, gcc 15, debug + opt — the same macOS cells that previously ran per-PR, with the same test selection.slow- orremote-marked tests, so the per-PR Linux run already covers everything that Linux would.pytestwith the same-k "not test_shallow_sphere"filter.Action versions (aligned with GeoClaw)
actions/checkout@v7.0.1,actions/setup-python@v7.0.0,fortran-lang/setup-fortran@v1.10.0,actions/upload-artifact@v7test-summary/action@v2.6(was v2.4).Caveats
nightly.ymlon the branch via Run workflow before merging.Verification
ubuntu-latestjobs, all passing.nightly.ymlon master and confirm both macOS legs pass.