Repository navigation
chore(pre-push): re-sync wiring block, drop file-wide disable - #164
Merged
Merged
Conversation
The shared template is now clean under shellcheck enable=all (ai-config#346, e6c3fecc), so the file-wide SC2249,SC2310,SC2311 disable this hook needed for the block alone (#160) is removed and the hook's own code is linted at full strength again. Block sha256 repinned to 554c1385. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RMRWKJ7P5L99pNgDqK3B8t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e6c3fecc(ai-config#346). The template is now clean undershellcheck --enable=all:casestatements have an empty*) ;;arm;ifwidens toSC1090,SC2310,SC2311.d556979b…to554c1385d10d77fac177df1a7aefdf6238e12ba009218689b7c5242fa24d4102.# shellcheck disable=SC2249,SC2310,SC2311, and the header note explaining it, are removed. feat(pre-push): load the shared push-content gate #160 needed it only for the block. Under this repo'senable=all.shellcheckrc, the hook now has 0 findings. As a positive control, the old block without the disable gives 5 in the same worktree.make test-hooksis green.Test Plan
554c1385…, equal toai-configorigin/master:docs/templates/pre-push-wiring, which the re-sync script asserts.tests/pre_push.bats), and no other references tod556979bor34cf3beeremain outside the frozen plan and spec docs.shellcheckis clean on the hook. The push ran this repo's pre-push gate, and it passed.Code review
SKIP: byte copy of ai-config@e6c3feccc111c757dc9a4735875734f4001f8362 (block region only). The block is a byte copy of the template, which ai-config#346 reviewed with 5/5 reviewers and no issues. The pin and citation edits are mechanical, so this PR is checked mechanically against the template's hash (Test Plan above) instead of getting a second 5-reviewer round. This is a deviation from the skill's file-level SKIP rule, stated here. Plan: ai-config
docs/superpowers/plans/2026-11-02-wiring-template-enable-all.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01RMRWKJ7P5L99pNgDqK3B8t