Repository navigation
test(deny): pin workflow deny calls and licence overrides - #163
Merged
Merged
Conversation
cargo-deny has no --ignore flag, so the RUSTSEC check only guards a re-added cargo audit. Narrowing a deny run (a dropped check, -A, --exclude) and relabelling a crate via clarify or exceptions both passed CI; pin them exactly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RMRWKKn1ZnoEgzb3hX8ewo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two gaps in
tests/test_deny_policy.py, reported by the math session's review and verified here:--ignore(error: unexpected argument '--ignore' found), sotest_one_ignore_list_no_workflow_has_its_ownonly guards a re-addedcargo audit --ignore(a real flag, so the test stays, with a corrected docstring). Droppinglicensesfrom the blocking line, or adding-A/--exclude/-t, passed CI. Newtest_workflow_cargo_deny_calls_are_pinnedpins every workflowcargo denycall exactly.[[licenses.clarify]]or[licenses].exceptionsentry can relabel a GPL crate as permissive while the GPL/MIT fixtures still pass. Newtest_licence_overrides_are_pinnedpinsexceptions = []and the singleringclarify entry (expression and licence-file hash).Test Plan
licensesfromci.yml; add-A unmatched-skip; add--exclude ringto the scheduled run; relabel ring asMIT; add a GPL exception; add a second clarify entrymake test— 1187 Rust, 200 Python, 16 bats passNot covered: a deny call moved into a script or Makefile target (none exists today) would bypass the workflow scan.
Code review
SKIP: two tests plus one CLAUDE.md sentence; mutation-verified. Not one of branch-code-review's three SKIP cases — disclosed rather than claimed.
Spec alignment
SKIP: no plan executed; follow-up guard for spec R2 of docs/cursor/specs/2026-10-31-rust-standards-edition-2024-spec.md.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RMRWKKn1ZnoEgzb3hX8ewo