Repository navigation
test(deny): pin advisory scope keys to all - #162
Merged
Merged
Conversation
The fixtures cannot see unsound/unmaintained; a revert to cargo-deny's "workspace" default (which hid RUSTSEC-2026-0306/0205) would pass CI. Matches math's key-level guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RMRWKKn1ZnoEgzb3hX8ewo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_deny_policy.pygainstest_advisories_cover_transitive_crates:deny.toml's[advisories]must setunsound = "all"andunmaintained = "all".unsoundto"workspace", which hid RUSTSEC-2026-0306 and -0205 until feat(deps): cargo-deny gate, unsafe guard, command.run env fix, edition 2024 #159 set"all"; before this test, reverting that line would pass CI.Test Plan
deny.tomland restored:unsound = "workspace"→ test fails;unsoundline deleted → fails;unmaintained = "workspace"→ failsmake test— 1187 Rust, 198 Python, 16 bats passNote:
ruff.tomltargetspy310while CI runs 3.13, so ruff groupstomllib(stdlib since 3.11) as third-party. Left as is; not this PR's concern.Code review
SKIP: one 9-line test plus one CLAUDE.md clause; mutation-verified. Not one of branch-code-review's three SKIP cases — disclosed rather than claimed.
Spec alignment
SKIP: no plan executed; follow-up guard for spec R2 of docs/cursor/specs/2026-10-31-rust-standards-edition-2024-spec.md.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RMRWKKn1ZnoEgzb3hX8ewo