Repository navigation
feat: richer bot-media overlays and configurable voice destination - #442
Merged
Merged
Conversation
jencompgeek
force-pushed
the
jh/support-bot-media-other-clients
branch
from
November 9, 2026 21:25
42d26e0 to
7418b61
Compare
14 of 16 tasks
jencompgeek
marked this pull request as ready for review
November 9, 2026 22:11
cbj0hns0n
approved these changes
Nov 10, 2026
cbj0hns0n
left a comment
Contributor
There was a problem hiding this comment.
Sent you a non-blocking DM about one issue with the socket & filed a follow-up ticket. Verified this works with the nextspace PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is in this PR?
Lets an organizer choose whether eventAssistant's voice output plays through NextSpace's
presentation view or through the Zoom bot's own camera/mic (
voiceDestination), and givesthe Zoom bot-camera feed visible state — a status badge (thinking/hand-raised/speaking), the
question it asked, and its name — instead of just an idle/animated character with no context.
Changes in the codebase
voiceOutput.voiceDestinationconfig (nextspacedefault,zoomopt-in) on eventAssistant,threaded through to
botMediaModeso the Zoom adapter knows whether to keep the bot's camerasilent (NextSpace speaks instead) or have it speak aloud into the call.
bot-media-server/page.ts: state badge, asked-question text, and name badge overlays on thebot camera feed, each wired to the existing
state/questionsocket events.max-width: 400pxmedia query: a wide/landscapecomposition (Zoom's bot-camera render, text overlaid near the bot) and a narrow/portrait one (a
small browser iframe embed, elements stacked in normal flow instead of overlapping) — the two
contexts differ enough in shape that one set of sizes couldn't serve both.
headless browser has no color-emoji font and would otherwise show a missing-glyph box.
Documentation and automated testing
Did you:
Testing this PR
Test in conjunction with FE PR berkmancenter/nextspace#244. See test steps there.
Additional information
The responsive split is viewport-width-driven (CSS media query), not an explicit "which client"
signal — it works because the iframe (~280px) and Zoom's render width sit on opposite sides of
400px today with real margin, not because the page knows which context it's in.