Repository navigation
feat: add a configurable pregame experience to eventAssistant - #436
Merged
Merged
Conversation
2 of 10 tasks
jencompgeek
marked this pull request as ready for review
November 6, 2026 15:42
jencompgeek
force-pushed
the
jh/pregame-feature-config
branch
2 times, most recently
from
November 6, 2026 21:55
2eb3190 to
fdfb807
Compare
jencompgeek
force-pushed
the
jh/pregame-feature-config
branch
from
November 9, 2026 21:00
fdfb807 to
3059a54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is in this PR?
Builds out the full pregame (pre-event early access) experience for
eventAssistantconversations. Organizers can configure how many minutes before the scheduled start
participants get early access to the room, a private warm-up question (organizer-written
or AI-generated, open text or single choice), and whether a recap of pregame activity
posts to the group chat once the event starts.
Also closes a gap where a conversation could still
be edited while it was already in its open pre-event window.
Changes in the codebase
pregamefeature toeventAssistant's conversation type(
src/conversations/eventAssistant.ts):preEventMinutes, warm-up question source(organizer-written / AI-generated) and format (open text / single choice) with friendly
option labels, and whether to post a recap on start.
— including one nested inside a feature's own config, like
pregame.preEventMinutes—directly onto the created conversation document instead of only into an agent's
agentConfig. Renamed the underlyingAgentProperty/resolveAgentPropertiestoPropertyBinding/resolvePropertyBindingssince it's no longer agent-specific.updateConversationnow also rejects edits while a conversation is in its open pre-eventwindow, not just while fully active, since participants are already engaging in the
pregame channel by then.
ConfigProperty.typeenum, which was missingarrayeven though it'sa supported type.
Documentation and automated testing
Did you:
No breaking changes and no new environment variables, so those two are n/a.
Testing this PR
Test in conjunction with FE PR berkmancenter/nextspace#240
eventAssistantconversation with thepregamefeature enabledtext vs. single choice); confirm the right prompt/options render in the private chat in the participant view within 1-2 minutes of pregame window opening
and confirm it's rejected with "Cannot update a conversation during its pre-event
window."
Additional information
The
propertyBindingsmechanism is general-purpose (not pregame-specific) — it's what letsany conversation type mirror a resolved feature-config value onto a real top-level field on
the conversation document, which
preEventMinutesneeded since several scheduling files(
preEventWindow.ts,scheduleConversationTimers.ts) read it directly off the documentrather than digging through
conversation.features.