Skip to content

fix(inbox): respect Codex provider authentication requirements - #3530

Open
qq2514568380 wants to merge 1 commit into
backnotprop:mainfrom
qq2514568380:fix/codex-provider-precheck
Open

qq2514568380 wants to merge 1 commit into
backnotprop:mainfrom
qq2514568380:fix/codex-provider-precheck

Conversation

@qq2514568380

Copy link
Copy Markdown

Summary

Fixes #3100.

New session currently rejects Codex when codex login status says it is not logged in, even when the selected custom provider reports requiresOpenaiAuth: false and needs no OpenAI account.

When the CLI reports signed out, consult the existing read-only Codex account reader before rejecting the launcher. Reuse the same Codex home and PATH, stop the reader afterward, and preserve the signed-out result if account discovery fails or still requires an absent account. Missing CLI, minimum version and Inbox connection checks remain in place. The regular signed-in path does not add a probe.

This changes launch eligibility, not provider credential validation. The provider can still reject its own credentials at request time.

Added regression cases for a no-OpenAI-auth provider and a failed account read, extending the existing fake CLI. Existing signed-out coverage still checks a provider that requires OpenAI auth.

Validation: TypeScript syntax parsing and git diff --check passed. Tests, builds, real Codex processes, browser checks and live linked-machine checks were not run. This change has only been statically checked.

e2e:

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inbox: make the Codex launch precheck respect providers without OpenAI account auth

1 participant