Repository navigation
fix(inbox): respect Codex provider authentication requirements - #3530
Open
qq2514568380 wants to merge 1 commit into
Open
qq2514568380 wants to merge 1 commit into
qq2514568380 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3100.
New session currently rejects Codex when
codex login statussays it is not logged in, even when the selected custom provider reportsrequiresOpenaiAuth: falseand needs no OpenAI account.When the CLI reports signed out, consult the existing read-only Codex account reader before rejecting the launcher. Reuse the same Codex home and PATH, stop the reader afterward, and preserve the signed-out result if account discovery fails or still requires an absent account. Missing CLI, minimum version and Inbox connection checks remain in place. The regular signed-in path does not add a probe.
This changes launch eligibility, not provider credential validation. The provider can still reject its own credentials at request time.
Added regression cases for a no-OpenAI-auth provider and a failed account read, extending the existing fake CLI. Existing signed-out coverage still checks a provider that requires OpenAI auth.
Validation: TypeScript syntax parsing and
git diff --checkpassed. Tests, builds, real Codex processes, browser checks and live linked-machine checks were not run. This change has only been statically checked.e2e: