Repository navigation
Inbox: mention a thread in a reply (drag a row, row menu, pasted link) - #3526
Draft
backnotprop wants to merge 7 commits into
Draft
backnotprop wants to merge 7 commits into
backnotprop wants to merge 7 commits into
Conversation
Piece 1 of the approved Dragging threads design, treatment A. A list row dragged onto the reply box, the row menu's Mention in reply (also on a phone's sheet), or a pasted thread link puts the thread's title in the words as a token. Send turns each into the thread's id at its spot plus a short list, worded by one constant pending approval. The sent message shows each mention as a link to the thread.
A rule that ends on the page itself is dropped from the cascade other apps load (tests/inbox-thread-css.test.ts).
The reply box under a held thread is a stronger tint with its label, never a dashed edge or ring; mention tokens lose their ring. A held thread near the list's top or bottom scrolls it, unless a drop target is under the pointer. The drag ghost's classes no longer share ib-tghost with the toast's buttons.
Mixed with --card it came out darker than the box in dark mode.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Piece 1 of the approved "Dragging threads" design (
.product/approved/inbox-drag-threads/, treatment A, "in the words"): mention a thread in a reply.What it does
@/#//tokens, with· projectadded when the project differs. ⌘/Shift-picked rows carried together become several mentions, comma separated. The box lights up as a drop target only while a thread is being carried. The thread the box answers is refused quietly. Escape, a window blur or a drop elsewhere cancels.#thread=msg_…link, or a bare thread id, gives the same token. Backspace removes a token whole. Archived threads show grey. Threads on another machine say they cannot be read from there."Title" (thread msg_…)at its spot, then a short list after the words. All of this wording is one constant,INBOX_THREAD_MENTION_WORDSinpackages/core/inbox-thread-mention.ts, and it is marked as pending the owner's approval.api.tschange: the Inbox is Bun-only, so no Pi server change is needed. Docs:inbox-compose.md,inbox-messages.md.Tests
packages/inbox/replyMentionsField.test.tsx(DOM), which covers:packages/inbox/threadMentions.test.tsandpackages/core/inbox-thread-mention.test.tscheck that the agent's words come only from the constant.e2e: inbox-row-menu.spec.ts inbox-picks-composing.spec.ts inbox-reply-quote.spec.ts inbox-attachments.spec.ts inbox-fullscreen-composer.spec.ts inbox-row-swipe.spec.ts inbox-row-pin.spec.ts inbox-thread-links.spec.ts