Skip to content

fix(update): bound diagnostic log reads to the last 64 KiB - #3518

Open
rudycelekli wants to merge 1 commit into
backnotprop:mainfrom
rudycelekli:codex-20261115b-update-log-tail
Open

rudycelekli wants to merge 1 commit into
backnotprop:mainfrom
rudycelekli:codex-20261115b-update-log-tail

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

Summary

Reading update diagnostics loaded the whole log and then took a slice in characters. Read only the final 64 KiB so an oversized multibyte log cannot bring an older diagnostic into the byte window.

Validation

The multibyte fixture failed on upstream and passed with the fix. It still reads the most recent diagnostic. Prepared with Codex assistance.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant