Skip to content

fix(dsh): only forward legacy stdout from a successful review - #3502

Open
rudycelekli wants to merge 1 commit into
backnotprop:mainfrom
rudycelekli:codex-20261115-dsh-failed-stdout
Open

rudycelekli wants to merge 1 commit into
backnotprop:mainfrom
rudycelekli:codex-20261115-dsh-failed-stdout

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

Summary

After a review window opened, a failed DeepSeek Harness CLI could print diagnostics to stdout. The adapter treated that output as reviewer feedback and could send it to the agent. Honor an explicit decision record and use legacy stdout only when the CLI exits successfully.

Validation

The exit-failure regression failed on upstream. All 35 focused DSH tests passed with the fix, including successful legacy stdout handling. Prepared with Codex assistance.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant