Repository navigation
SPIKE (do not merge): free layout with @pierre/layouts - #3452
Draft
backnotprop wants to merge 1 commit into
Draft
backnotprop wants to merge 1 commit into
backnotprop wants to merge 1 commit into
Conversation
Vendors @pierre/layouts (Apache-2.0, unpublished) verbatim under packages/vendor-pierre-layouts/upstream with a wrapper, a sha256 manifest, a check script and its test. Adds the Inbox free-layout spike behind INBOX_LAYOUT_SPIKE=1 and ?layout-spike.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPIKE. Do not merge. This branch tries Pierre's
@pierre/layoutsengine for a free multi-pane layout beside the Inbox list (multi-thread view, option D).What is here
packages/vendor-pierre-layouts/: a pinned, verbatim copy of@pierre/layouts(Apache-2.0; the package is private and not on npm).upstream/holds their files byte for byte.src/is our wrapper, and the app imports only that.patches/is empty.UPSTREAM.mdrecords the source, the commit, the files left out and a sha256 manifest.NOTICE, and aREADME.mdthat says how to check against upstream, update, patch and retire it.scripts/check-vendored-pierre-layouts.tschecks the manifest. Its test fails on any edit insideupstream/, or on any import ofupstream/from outside the package.packages/inbox/spike/: the layout.localStorage.Gate
The spike exists only in a build run with
INBOX_LAYOUT_SPIKE=1:?layout-spikeand at 900 px wide or more.Known
tests/inbox-structure.test.tsfails:packages/inbox/App.tsxgoes over its line ceiling by 11 lines. This is acceptable for a branch that never merges.