Skip to content

Code review redesign - #3383

Draft
backnotprop wants to merge 508 commits into
mainfrom
integration/review-next
Draft

backnotprop wants to merge 508 commits into
mainfrom
integration/review-next

Conversation

@backnotprop

@backnotprop backnotprop commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

The code review redesign as one branch. It merges every piece below (merge commits only, nothing rebased), plus main, so the redesign can be tested in its final state and land together. It lands as a merge, not a squash, so each piece keeps its history. Draft: the owner decides when it lands.

What it contains

Where the pieces met

Each place where two pieces met was resolved by hand on this branch. These are where bugs are most likely, so the list stays as a record. The full list, with each conflict, is in the integration notes (integration.md, outside the repo). The main ones:

  • Pierre tree + layout: "Open to the side" in the tree row menu; the pane tabs focus the Pierre row; the layout spec selects Pierre rows.
  • Semantic diffs + minimap: semantic notes in the All changes minimap (AllFilesCodeView.tsx).
  • Minimap + layout: the minimap in the Original view (OriginalFileView.tsx, whole-file on the old side) and in the panes' Current view, off on phones.
  • Layout + critic window: FileHeader.tsx keeps the layout's structure with the critic's count format, narrow-width menu, ligatures and overflow fixes. On phones it now keeps the critic's padding when the pane has tabs.
  • Changes, Threads and References tabs together in the right panel (extraTabs).
  • Live window + main's owner-only Tailscale change: the live-review route and machine checks.
  • packages/inbox/components/Thread.tsx (the Inbox window stack + live window): the review anchor line and Open the review kept; the reply-feedback imports went with main's move to useBodyText.
  • apps/hook/server/index.ts: live review imports kept alongside main's GIT_REPO_ENV.
  • Speed (Review: large diffs on par with Pierre #3391) + semantic diffs: AllFilesCodeView.tsx keeps Review: large diffs on par with Pierre #3391's whole-file prefetch and warm-up; semantic diffs start from the prefetched text once it fits the patch, and their item swap waits for scroll rest.
  • Layout + critic window, narrow headers: one container-query switch. Under 360 px, Stage, Comment and Edit hide and the one file menu offers them.
  • Critic window + live window: one rule keeps annotation rows plain, in the shared theme.
  • Review: no lost taps after a scroll; first code sooner #3413 + layout: the tree's deferred mount sits in FileTree.tsx, which the two-pane layout uses, with its space reserved.
  • Image sizes: the header height hint uses the known image sizes, so images no longer shift the page on load.
  • Dependencies: the lockfile is main's plus what the redesign adds (see below). package.json is checked against main line by line each round.
  • tests/dom-test-list.txt: both sides kept once each; FileTree.redraws.test.tsx dropped with the old tree.
  • Main's Open in at a line (Open in: JetBrains IDEs, at the line #3372) + the moved Open in: main added a line to "Open in" in the file header. Here the header's Open in button was moved (left of Viewed, with its extra menu items), so the line goes to that button and to the phone header's menu (CompactFileActions.tsx) instead of to main's old spot, which is dropped. DiffViewer.tsx keeps main's line reader beside the minimap switch.
  • apps/hook/server/index.ts: main's loopback-no-proxy import stays first; the live review import follows it.
  • apps/pi-extension/vendor.sh: this branch's list (no tour or semantic-diff, plus review-live, sem-diff-assets, sem-diff-opinion) plus main's open-in-locate, path-segment and loopback-proxy.
  • packages/guide-viewer/GuideFileCard.tsx: main's Collapse all fix (Guide viewer: Collapse all works after switching views #3467) and this branch's header heights merged cleanly; read by eye.
  • tests/inbox-size-ceilings.json: the ceilings are the merged sizes (App.tsx 6600, Thread.tsx 6056, AttachmentPane.tsx 3207). None is above main's.

What was verified, and where

All runs were local, on the candidate's own build, with one browser turn per spec or probe. Speed is compared with Pierre's demo and the previous round, measured back to back in the same window.

  • Round 34j (5246aff), the candidate: 34i plus the review tree polish (f257789) and main at 341ab8d (06d1d29, then 341ab8d, with Open in: JetBrains IDEs, at the line #3372, Keep machine state out of config.json (#2852) #3458 and Guide viewer: Collapse all works after switching views #3467). Checks on the final head:

    • frozen install
    • typecheck green, run alone before the lanes; the build (review, hook, opencode) run alone after them
    • heavy-mod 26 + 4 + 4, heavy-agents 13, unit-1 7235, unit-2 7604, unit-3 6408, dom-1 1798, dom-2 1993, dom-3 1759, dom-4 1814, isolated DOM 48, file browser 7, guards 20 (with the Inbox structure guard and the size ceilings)
    • Three failures, none of them this branch's: unit-2's packages/server/inbox-open-in.test.ts:652 expects open -a WebStorm <path> where main's launcher now gives open -na WebStorm --args --line 12 <path>, and it fails the same way on a clean main (341ab8d). dom-2's usePaneOpens.test.tsx:166 is a garbage-collection check that passed 7 of 7 three times alone. The first heavy-agents and heavy-mod runs failed before the build existed; with the build they are green.
    • App.panelView.test.tsx: this branch's two grouping checks read the tree before it mounts (it mounts after the first code or 400 ms), so they passed in their lane but failed alone. The test now waits for the tree; it passes alone 3 of 3.
  • Browser specs on 34j's build (5246aff), one browser turn per file:

    Spec Result
    review-diagrams 5/5
    review-explorer 3/3, :341 skips itself here (no ripgrep)
    review-file-list-stays-put 5/5
    review-image-swipe 2/2
    review-launch-pad 1/1
    review-layout 4/4
    review-live-threads 2/2
    review-live-threads-webkit 1/1
    review-semantic-diffs, three times 12/12
    review-sidebar 4/4
    review-wheel-no-sideways, three times 12/12
    inbox-code-review 17/17, 1 skip (video)
    inbox-pull-requests 54/54, 2 skips (video)
    inbox-machine-update 4/4, 1 skip (needs an older release binary)
    packed-page-load 12/12
    ref-cards-review 7/7
    inbox-show-me 15/15
    inbox-guides 13/13
    inbox-review-jumps 4/4
    inbox-show-me-part 14/14
    inbox-review-selection-bar 11/11
    inbox-request-guide 4/4

    inbox-guides runs with the binary named plannotator: its stop step checks the process name.

  • Speed on 34j (5246aff), three runs at load 7 to 9.4, with 34i and Pierre's demo in the same turns, the order alternating:

    34j 34i, same window Demo, same window
    First code, 200 files 90 to 106 ms 92 to 97 ms 46 to 66 ms
    First code, sample 87 to 94 ms 86 to 87 ms 41 to 44 ms
    Scroll, 200 files 58.6 to 60.2 fps, no frames over 33 ms 59.3 to 59.9 fps, 0 to 2 over 33 ms 60.3 to 60.6 fps

    Eight more pairs on 200 files, alternating, at load 7.7 to 10.3: 34j 88 to 94 ms (median 90; one 119 on the first launch of a turn), 34i 87 to 91 ms (median 89.5), so no change. Load layout shift 0.0055 on all three runs.

  • Round 34i (9b25b46), the candidate: 34f plus the sem-jiff package switch, the Sem tab name fix, the wheel fix with Pierre sem.6, then main at 3810fba (11 merges). Checks before the main merge (4dcab86):

    • frozen install; the lockfile names sem.6 and its hash matches the vendored tarball; pierre-drift matches upstream
    • typecheck green; heavy-mod and heavy-agents (13) green; unit-1 6808, unit-2 6842, unit-3 7381; dom-1 1779, dom-2 1894, dom-3 1734, dom-4 1899; isolated DOM 48, file browser 7, guards 20 (with the Inbox structure guard); all passing
    • scripts/install.test.ts alone three times: 327 of 327 each
    • build: review, hook, opencode
  • After the main merge (9b25b46): typecheck green, guards 20 (Inbox structure on the merged result), heavy-mod and heavy-agents (13) green, unit-1 6661, unit-2 7719, unit-3 6692, dom-1 1787, dom-2 1901, dom-3 1736, dom-4 1899, all passing.

  • Browser specs on the merged build (9b25b46), one browser turn per file:

    Spec Result
    review-diagrams 5/5
    review-explorer 3/3, :341 skips itself here (no ripgrep)
    review-file-list-stays-put 3/3
    review-image-swipe 2/2
    review-launch-pad 1/1
    review-layout 4/4
    review-live-threads 2/2
    review-live-threads-webkit 1/1
    review-semantic-diffs, three times 12/12
    review-sidebar 4/4
    review-wheel-no-sideways, three times 12/12
    inbox-code-review 17/17, 1 skip (video)
    inbox-pull-requests 54/54, 2 skips (video)
    inbox-machine-update 4/4, 1 skip (needs an older release binary)
    packed-page-load 12/12
    ref-cards-review 7/7
    inbox-show-me 15/15
  • Speed on 34i (4dcab86), three runs each, at load 3.5 to 4.7, with 34f and Pierre's demo in the same turns:

    34i 34f, same window Demo, same window
    First code, 200 files 88 to 94 ms 84 to 86 ms 45 to 55 ms
    First code, sample 82 to 87 ms 84 to 88 ms 36 to 41 ms
    Scroll, 200 files 59.7 to 59.8 fps, 0 to 1 frames over 33 ms 59.7 to 59.9 fps 60.2 to 60.5 fps

    Eight more pairs on 200 files, 34i and 34f alternating: 34i 85 to 94 ms (median 87.5), 34f 86 to 92 ms (median 87), so no change. Load layout shift 0.0055 on all three runs.

  • Round 34f (06a89a1): round 34e with two changes. First, the vendored Pierre semantic build is now sem.5: connector bands read in dark themes at 32% alpha with a 1 px edge, and light themes are unchanged. Second, Sem tab renames read old → new in every language, and long paths keep the file name (fix/sem-tab-rename-names). Checks on it: pierre-drift matches upstream, typecheck green, review DOM 641/641, semDiff 69/69, review-semantic-diffs 4/4. The 34e shards stand for it, because neither change touches the Inbox.

  • Round 34e (0d4fb01): round 34d plus main at 233c27f (13 Inbox merges). Checks on it:

    • typecheck green
    • all nine lanes: heavy-mod, heavy-agents, unit-1 6990, unit-2 7175, unit-3 7211, dom-1 1936, dom-2 1670, dom-3 1780, dom-4 1919, all passing
    • review-editor unit 919, isolated DOM 48, guards 8
    • every review spec, plus inbox-action-copy-blocks: all green (review-explorer :341 skips itself here: no ripgrep)
    • speed against Pierre's demo in the same turn, at load 8.5 to 10.6: first code 92 to 98 ms on 200 files (demo 45 to 54), 89 to 95 ms on the sample (demo 38 to 48); scroll on 200 files 59.2 to 59.6 fps with 1 to 2 frames over 33 ms (demo 60.2 to 60.6); load layout shift 0.0055 to 0.0061
    • the 16 Inbox shards are running on it
  • Round 34d (f76bb0a): round 34c plus a fix for a race in the All changes view's line target: a click in the Sem tab could land on a file whose header never rendered (fix/sem-click-header). It also has a layout-proof dark-page check in packed-page-load.spec.ts: after mount it counts light pixels instead of reading the centre pixel. Checks on it: typecheck green, review DOM 640/640 in the review-editor list, and Inbox shard 13 (where review-semantic-diffs.spec.ts:211 had failed twice) run whole twice: 149 passed, 1 skipped, both times.

  • Round 34c (84a8f5d): round 34b plus the Sem tab's name finder for all eleven languages (fix/sem-names-per-language): typecheck green, review DOM 1059/1059, unit and guard 884, semDiff tests 40/40, review-semantic-diffs 4/4.

  • Round 34b (d226398): round 34 plus the fix for the active tab name (fix/tree-name-layout cd0b074). Checks on it:

    • typecheck green
    • review DOM 1059/1059, unit and guard 884
    • review-explorer 3 passed, 1 skipped (:341 skips itself here: no ripgrep binary on this Mac)
    • review-layout 4/4, review-sidebar 4/4, inbox-action-copy-blocks 6/6
    • c200 scroll 58.9 to 60.3 fps with 0 to 1 frames over 33 ms; first code 84 to 102 ms (load 6.8 to 7.1)
    • The Inbox shards ran on round 34 (ed4c43b). They stand for 34b to 34d, whose changes are in the review window (name fitting, the Sem tab's names, the line-target race) and one spec.
  • Round 34 (ed4c43b):

    • typecheck green
    • review and UI DOM 1058/1058, unit and guard 884
    • lane unit-2 (with the Inbox structure guard) 6863 pass, lane dom-4 (Inbox and Settings) 1912 pass
    • sem-diff 372/372
    • both servers' tests 6152 pass, 1 flaky (see known open)
    • npm-check-updates absent from bun.lock
    • build OK
  • Earlier rounds' full lanes: round 31: dom-1 1720, dom-2 1811, dom-3 1683, unit-1 6920, unit-3 6918, heavy-mod and heavy-agents green. Round 33: dom-1 1567, dom-2 2057, dom-3 1891.

  • Browser specs on round 34:

    Spec Result
    review-diagrams 5/5
    review-file-list-stays-put 3/3
    review-image-swipe 2/2
    review-launch-pad 1/1
    review-layout 4/4
    review-live-threads 2/2
    review-live-threads-webkit 1/1
    review-semantic-diffs 4/4
    review-sidebar 4/4
    inbox-action-copy-blocks 6/6
    review-explorer 2/3 (:217, the cut tab name, fixed in 34b)
  • Speed on round 34, three runs each, interleaved with Pierre's demo in one turn:

    Round 34 Demo, same window
    First code, 200 files 89 to 105 ms 43 to 69 ms
    First code, sample 86 to 99 ms 36 to 49 ms
    Scroll, 200 files 58.7 to 60.6 fps, 0 to 2 frames over 33 ms 60.2 to 60.6 fps

    Load layout shift: 0.0066 to 0.0072 on the sample and the demo fixture, 0.0035 on the worst fixture (bar under 0.1). Details: perf-vs-pierre.md.

  • Break-UI recheck on the five worst-case fixtures: 28 of 28 rows fixed (break-ui/recheck-2.md), with row 9 reopened on round 34 and closed again on round 34b.

  • Critic findings and what each fix answered: critic/findings.md.

  • Those notes are in the owner's review-redesign briefs folder, not in the repo.

Known open

  • Full browser suite: by the owner's rule of 2026-11-15, the full browser suite runs on main after the merge. This PR ran the 11 code review specs and the 11 Inbox specs that cover the Inbox files it touches and the jump list and Guided Review subheads the kind order drives: inbox-code-review, inbox-pull-requests, inbox-machine-update, packed-page-load, ref-cards-review, inbox-show-me, inbox-guides, inbox-review-jumps, inbox-show-me-part, inbox-review-selection-bar and inbox-request-guide (table above).
  • First code against Pierre's demo: about 40 to 50 ms behind on 200 files and on the sample, measured in the same window.
  • Inbox browser suite on round 34 (ed4c43b), 16 shards: 2160 passed, 31 skipped, 5 failed. None of the failures is open against this branch:
    • inbox-reply-draft-files.spec.ts:80 is main's own race. Main's binary fails it 2 of 3.
    • packed-page-load.spec.ts:74 was the spec's single-pixel read; the spec is fixed in 34d.
    • review-explorer.spec.ts:217 is fixed in 34b.
    • review-semantic-diffs.spec.ts:211 is fixed in 34d; shard 13 is green twice.
    • inbox-keyboard-journeys.spec.ts:560 is the known Mac-only failure.
  • On main too: packages/server/inbox-open-in.test.ts:652 (Open in WebStorm at a line, the macOS launch) fails on main at 341ab8d. packages/inbox/reviewPaneGuide.test.tsx fails its first one or two tests when run alone in a cold process on main as on this branch (its reader loads lazily and the test waits six ticks); in its lane it passes.
  • Flaky server test: packages/server/inbox-ended-reply.test.ts fails on main too (1 of 20 there, 3 of 20 here, run alone).
  • inbox-pull-refresh.spec.ts:165 failed once on GitHub's runner. It passed 12 of 12 locally against this branch's binary and against main's.

Dependency changes

The lockfile is main's, plus what the redesign adds:

  • @pierre/diffs 1.6.4 → 1.7.0-beta.3, with @pierre/highlights 0.5.0/0.5.1 and the new @pierre/patches 0.0.1.
  • @pierre/diffs-sem from our fork's tarball (sem.6).
  • New:
    • @pierre/trees 1.0.0, with preact 11.0.0-beta.0 and preact-render-to-string 6.6.5.
    • @plannotator/sem-jiff 0.2.0 from npm, pinned exactly, with @vscode/diff 0.0.2-133 and web-tree-sitter 0.27.1. It carries its grammars as wasm files (THIRD-PARTY-NOTICES inside the package); the review build copies them with its sem-jiff-copy-wasm command. A grammar loads only for files of its language. No tree-sitter npm packages and no vendored grammar remain in the repo.
    • bunfig.toml adds @pierre/trees and @plannotator/sem-jiff to minimumReleaseAgeExcludes, beside the other Pierre and Plannotator packages.

One side effect reaches beyond code review:

  • shiki and every @shikijs package move 4.4.3 → 4.5.0 for the whole app. The Inbox and plan review colour code with it too. packages/inbox/package.json pins 4.5.0 since the move to @pierre/diffs 1.7.

Fork notes

  • patches/FORK.md: the patches on top of upstream packages.
  • vendor/pierre-diffs/FORK.md: our vendored fork of @pierre/diffs (1.7) and what differs from upstream.

Behaviour changes

  • Code Tour is gone from the review window and from /api/agents/capabilities. Git status is folded into the tree.
  • The file tree is Pierre's tree:
    • Changes and All files views.
    • Rows are 44 px on phones.
    • Long names are cut in the middle by grapheme, so an emoji is never split.
  • Layout:
    • Two panes, with tabs in the header and Diff · Current · Original per file. DockView sits behind a flag.
    • The phone layout is reworked.
  • Semantic diffs: a "Semantic diff" toggle, a Sem tab, and semantic marks in the minimap.
  • The old third-party sem tool is gone, so the built-in engine feeds the Sem tab alone. Languages the engine does not read show the plain diff.
    • Removed: the installers' download, the env vars PLANNOTATOR_SEM_PATH and PLANNOTATOR_SEM_VERSION, GET /api/semantic-diff in both servers, the semanticDiff reply field, the Analysis "Semantic changes" switch, and the "sem · N" badge.
  • Power Up: a second model's opinion on semantic diffs. It stays off until a key is set and then shows as a Settings group (Settings > Semantic diffs > Power Up).
  • Image diffs:
    • Side by side, swipe and onion skin.
    • Checkerboard, Light or Dark background.
    • Size and byte change shown.
  • A minimap on long diffs, with Auto, Always and Off.
  • Launch: one launch pad for Guided Reviews and review agents, guides organised, current models.
  • Live review threads (needs the Inbox):
    • Comments become threads with agents, shown under their lines with Queued, Delivered and Read.
    • A Threads tab.
    • "@" an agent to send a comment now.
    • Send and Send all.
    • A review opened again shows its threads, re-anchored.
    • The Inbox can open a living review from its thread.
  • Smaller notices: "Mode changed", "Empty file" and "Symlink: a → b".
  • Every diff answer (/api/diff, /api/diff/switch, /api/pr-switch, /api/pr-diff-scope, in both servers) carries imageSizes. The server reads them within 250 ms and leaves them out if it takes longer. /api/review-image-sizes stays as the fallback, and SVG sizes are now read too.
  • A tap or click right after a scroll is no longer lost (pointerEventsOnScroll).
  • In All changes, a vertical wheel over a long line no longer scrolls the diff sideways.
  • The changes tree mounts once the first code has painted. Its space is reserved, so nothing moves.

Agent-facing wording changes

Tool descriptions, skills, CLI --help, the mod's contract and INBOX_TOOL_COST are unchanged. New or changed text an agent reads:

Where Before After
/api/agents/capabilities lists { id: "tour", name: "Code Tour" } no tour entry; TOUR_REVIEW_PROMPT and its schema deleted
Pi README "Review agents, Code Tour and Guided Review still run their own models." "Review agents and Guided Review still run their own models."
Marketing prompts.md "(Claude, Codex, and Code Tour) all shell out" "(Claude and Codex) both shell out"
Delivered text of a review comment (nothing) (A review comment on \` lines - (<new|old> side, at ):+ the lines in a fence +Answer it with reply_to .)`
Delivered text of a review sent all at once (nothing) (A code review of N comments. Answer each comment with reply_to its id, so the answer lands on its lines; answer the review as a whole with reply_to <lead id>.), then per comment Comment <id> on <place>: + fence + words
The lead's words when the person adds none (no such message) N comments on the code.
A reply further down a comment's thread (nothing) (On the review thread about \` line N ( side, at ); answer with reply_to .)`
read_thread, a comment in full (nothing) the review comment block, then The person resolved it. when resolved
read_thread, one-line form (nothing) review comment on <place>[, resolved]
The wake's title for a review thread the thread's subject Review: <branch or PR title>
A decision in a review opened from its Inbox thread (no such review) the feedback export, or I approved the review., or I approved the review, with notes: + the export

The live-thread wording was tested clean room in #3338: a fresh agent given only the delivered text answered each comment by its own id.

…ields get real labels

The whole row used to dim, leaving the title at 3.5:1 and the hint at 2.5:1.
The 10 px caption inside each key field read like a placeholder; each field
now has a 13 px label above it.

Claude-Session: https://claude.ai/code/session_01VJ6b1nJDj5YogGsP3Ymd9m
…abs hide whole into a counted menu, titles keep their extension, the view switch folds in a narrow pane

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
…slot

The reserved pair is drawn as two disabled arrows at reduced opacity, so the header has no 60 px hole between Approve and the split button and still never shifts.

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
…eight

The Unicode ∆ becomes lucide Diff at 14 px, in the muted text colour like the row's label. The panel action rows (All changes, PR pages, Semantic diff, Call flow) are 24 px like the tree rows beside them, and 44 px in the phone shell.

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
In the phone shell the Changes and All files trees use 44 px rows (the tree's itemHeight option, keyed so it redraws when the shell changes), and the viewed circle and git add targets are 44x44 through the ::part styling seam; the icons keep their size. Desktop rows stay 24 px. The Pierre patch is unchanged.

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
The trail's badge column was reserved on every row whenever the tree was grouped, only for the group headings' viewed/total, so names like monthly-report.ts were cut with about 30 px free. Headings now get their own trail columns (::part(row-trail-heading)); file and folder rows reserve a badge column only when a file has a badge.

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
'Claude · Sonnet 5.5 · …' cut the model. The summary line now gives way in the engine name and the options first; the model name never shrinks (it only truncates if it alone is wider than the row). The whole line stays in the title.

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
… the gear; hover label stays below the file header

Auto shows the strip when the content is taller than three screens, or
taller than one screen when a file has more than 1,000 lines. The gear's
switch becomes Minimap: Auto / Always / Off. The hover label follows the
pointer and is clamped below the sticky file header.

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
…dge pixel on its own side

At DPR 2 a 100% image is smoothed across each edge (rgb 159,96,159 is a
quarter of the neighbour, as bilinear filtering gives); a one pixel drift
would read the neighbour whole. The test now reads the half of each edge
pixel that lies away from the edge, and saves an edge crop when asked.

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
…l edge

It used to show whenever the pointer was anywhere over the panel, so with the Pierre tree it sat on the count column (−10). It stays inside its panel, beside the edge, and appears on hovering the edge or on keyboard focus.

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
…rker

The label lost its truncate class when the scope switch stopped truncating, so review-sidebar.spec.ts:209 waited for an element that no longer exists. It now measures [data-tree-scope-label]; the spec passes (4 of 4) against this branch's binary.

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
DiffDisplayOptions.tsx: take the minimap's Auto / Always / Off row in place of its old switch, with the critic's divider spacing (my-2 -mx-2). ReviewDockRightActions.test.tsx: the switches are now Wrap, Line numbers, Backgrounds, Whole file, Hide whitespace, and semantic diffs' Show moved & renamed code (the minimap is a segmented row, not a switch).

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
App.tsx: take the layout's HeaderBranch for the repo header; keep the critic's gap-2 on the phone's branch line inside HeaderBranch. FileHeader.tsx: keep both the group/file-header class (the quiet open-in and hover reveals use group-hover/file-header) and the layout's @container/file-header.

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
…agent's icon as the Inbox does

The Inbox's own marks (ui inbox-thread HostMark and AuthorMark): the brand mark per agent, the neutral glyph for an
unknown one, the reply glyph for your own messages, in the Inbox's 24 px message-header tile with no added height.
ui's mention picker takes an optional mark per person.

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
…fitted to their room, keeping the extension, with the ellipsis against it

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
FileTree.tsx imports: keep the critic window's focusFileHeaderWhenLost and the critic tree's useCompactTouchLayout.

Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
# Conflicts:
#	packages/inbox/parts/MessageBodyView.tsx
#	packages/ui/HANDOFF.md
#	tests/dom-test-list.txt
#	tests/inbox-size-ceilings.json
…repo engine

Delete packages/sem-diff and vendor/tree-sitter-kotlin. Shared, review-editor,
the review app and the Pi extension (dev) depend on the package. The wasm list
and grammar map come from @plannotator/sem-jiff/grammars, which adds Swift;
the review build copies the wasm with the package's sem-jiff-copy-wasm, the
binary embeds Swift, and Pi vendors the package's src files.
…he file name whole

A rename entry takes its names from the engine's rename spans, one row per renamed name, keeping PHP's $ and Ruby's @ and : sigils. The file header in the Sem tab cuts folders first and fits the file name with the shared EllipsisName fitter.
Replaces the sem.4 tarball with sem.5 (sha256 15b785697eb0...), fork.patch from
pierre-diffs (git diff 3eb8f393, version 1.7.0-beta.3-sem.5), and FORK.md's
change (5). Light bands are unchanged at 15%; dark bands are 32% alpha with a
1 px 50% edge.
… left edge on both sides

Split view, All changes: a file with a long line whose change is far right, drawn
only once wheel steps bring it near, with the pointer over the old side and over
the new side. Fails on integration/review-next (both sides land 13848 px sideways).
All changes ran revealFirstChange on every file's first render, and a file is
first rendered when scrolling brings it near. So a vertical wheel step scrolled a
file with a far-right change sideways, and the split view's side sync and the
bottom bar carried it to the other side. The reveal now runs only for files drawn
before the reader scrolls: the ones the view opens on.
…the dark edge

Replaces the sem.4 tarball with sem.6 (sha256 635cb63d7557...), which carries
sem.5's dark-theme bands (32% fill with a 1 px 50% edge; light unchanged at 15%)
and change (6): a band whose ends span the same rows carries data-connector-level
and draws without the edge, which outlined it as a rectangle. fork.patch is git
diff 3eb8f393 on plannotator/diffs-fork at 006a785d.
Pin the four dependency lines to the published 0.2.0 and exempt the package
from the minimum release age, like the other @plannotator packages.
… new renames test

semDiffChanges.renames.test.ts (from integration) imports the package. The code
review guide says where the engine lives, how it is wired and where its
THIRD-PARTY-NOTICES file is.
The Sem tab's file header sits under tabular-nums, which in Inter widens the
hyphen from 6.05 to 8.41 px; the canvas measure ignores it, so a cut name with
hyphens drew past its box. Fitted names and the Sem path use normal numerics.
… view

Next/previous file, a Guide outline jump, a Sem tab entry and a comment jump now
mark their file to reveal its first change once its changed characters are drawn
(within 2 s), whether the jump renders the file or lands on one already drawn.
Wheel and other passive scrolling still never reveal. A tree click opens the file
in its own tab, where DiffViewer already reveals it.

The browser proof adds a tree click and a next-file jump after scrolling: the
far-right file shows its change and the other files stay at the left edge.
# Conflicts:
#	bun.lock
#	package.json
#	vendor/pierre-diffs/FORK.md
#	vendor/pierre-diffs/fork.patch
# Conflicts:
#	apps/pi-extension/vendor.sh
#	packages/review-editor/components/DiffViewer.tsx
#	packages/review-editor/components/FileHeader.tsx
#	packages/ui/components/OpenInAppButton.tsx
#	tests/inbox-size-ceilings.json
…s, wrap the tools row when it does not fit

Compact rows (under 220 px) hide only the numbers; Git add moves into the lead beside the viewed mark. The tools row wraps whenever the pills and tools do not fit, so Collapse all files never draws over All at 256 px with a long count. Merge the viewed pressed rules, fix the File kinds heading order and the touch wording in the guide, drop the spec header lines.
# Conflicts:
#	apps/hook/server/index.ts
#	apps/pi-extension/vendor.sh
#	tests/inbox-size-ceilings.json

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant