Repository navigation
Pull request cards say why gh or glab could not answer - #3093
Draft
backnotprop wants to merge 26 commits into
Draft
backnotprop wants to merge 26 commits into
backnotprop wants to merge 26 commits into
Conversation
…hared words Six states (missing, signed out, timed out, refused, rate limited, failed), read from the run and, where the run is vague, from a cached status check with its own deadline. A thread's PRs and the hover cards carry the problem beside the older error code; the tool's own words stay on the server. Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
An icon, the bold line, the muted line, and Copy for the sign-in command or Try again, under what the Inbox knows. Link hover cards and the Pull requests page use the same words. Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
The list can draw a line above the rows (the notifications banner) while a card is open; the row slid from under the resting pointer, the browser sent a leave the person never made, and the card closed. Now a move off the mark and the card, or out of the window, closes it; the read is still cancelled when it does. Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
A self-hosted merge request showed its full URL as its title and in "Remove … from this thread". Now group/project!45, with the host in front only off github.com and gitlab.com (forgePullRefShort, beside forgePullRefText, which stays what agents write back). Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
It had a fixed height and no wrapping, so a long name ran out of the sheet. Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
smoke:package: the core source manifest gained ./problem and ./problem-words, which the published core 0.25.22 lacks. core is 0.25.24 (main took 0.25.23 for ./call-tree, #3086; this branch is stacked on #3082) and ui pins it exactly; bun.lock changes only the two core version lines (set by hand), and HANDOFF's Publishing & versioning lists it. When this branch meets main, core takes the higher version and keeps every subpath. Publish core first. Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
On CI's Linux, /usr/bin holds a real gh, so the "not installed" case found and ran it (Bun read a timeout, Node a sign-in). The fake folder alone is on PATH now: the fakes need nothing else. Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
Core stays 0.25.24 here, on top of main's 0.25.23 (the Call tree). Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
A quiet action after each tool state's own next step, on the PR card, the Pull requests page and link hover cards. One press opens New message filled in (openComposer): To the thread's agent, "Look into: <the line>", and a body that is the redacted report plus the ask, ending with a once, yes-only offer to send an anonymous report with `plannotator feedback`. - core/problem-report.ts: problemReport and redactReportText (tested). - server/inbox-problem-facts.ts: an in-memory log of failed forge runs (redacted as kept) and GET /api/inbox/problem-facts. - ui: ProblemNotice `extra` and the refCardProblemExtra seam (additive). Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv # Conflicts: # packages/inbox/threadPulls/ThreadPulls.tsx
…heet; the Pull requests line's ask too Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
…un it came from The tool log took every host out as a run was kept, so a run that named no --hostname showed the forge's own host as <host> while another kept it. Now tokens, emails and the home path go as it is kept, and every other host when it is read for the report. Tested. Claude-Session: https://claude.ai/code/session_01VJ6b1oES3jfkCyDmf8uKzv
| "Authorization: Bearer abc.def.ghi-123456", | ||
| "Cookie: _gitlab_session=abcdef123456", | ||
| "GITLAB_TOKEN=supersecretvalue1 glab api", | ||
| "token eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiIxMjM0In0.c2lnbmF0dXJl", |
# Conflicts: # apps/pi-extension/vendor.sh # docs/agent-guides/guides-and-shared-ui.md # docs/agent-guides/inbox-notifications-and-agents.md # docs/agent-guides/server-and-storage.md # packages/core/forge-ref-card.ts # packages/core/package.json # packages/inbox/App.tsx # packages/inbox/api.ts # packages/inbox/threadPulls/ThreadPulls.test.tsx # packages/inbox/threadPulls/ThreadPulls.tsx # packages/server/inbox-thread-pulls-route.test.ts # packages/server/inbox-thread-pulls.ts # packages/server/inbox.ts # packages/shared/ref-cards.ts # packages/ui/HANDOFF.md # packages/ui/components/RefHoverCard.tsx # packages/ui/configure.ts # packages/ui/package.json
…ver named in a command - Each state is one short title, at most one short line, one next step. - After the merge with main: a host gh or glab lists no login for is signed out at once, with no status check naming it. - Bitbucket hover and PR cards keep their own lines; no gh or glab words on them. - The command row is plain text with Copy, not a boxed well. - The thread PRs reader and the facts query move out of api.ts (ceiling lowered to 2378).
# Conflicts: # apps/pi-extension/vendor.sh
…from inbox-test The relay-pin and held-copy drift guards on main require both for an Inbox browser spec.
# Conflicts: # packages/core/forge-ref-card.ts
…in after signing in; no Ask your agent to look - One rule (commandHostTrusted) for every surface: a sign-in command and "isn't signed in to <host>" name only github.com, gitlab.com, a host in the CLI's own configuration, or the project's own origin host. Any other host gets the plain line and no command. - Not installed says missing on a self-managed host too. A configured host that cannot be checked reads failed or timed out, never signed out. - missing and signed_out offer Try again; ?retry=1 reads the CLIs' hosts and the status check again, so the card recovers right after a sign-in. - A PR numbered 429 or a project named svc-401 is not a rate limit or a sign-in problem. - Removed Ask your agent to look (control, problem-facts route, report builder, spec, docs); kept on feat/inbox-ask-agent-to-look.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Inbox asks gh or glab for pull or merge request data and cannot get it, the card now says which of six states it is. Each state has one short title, at most one short line, and one next step. Before, the best it could say was "The Inbox did not answer. Try again in a moment."
The words
gh auth login --hostname github.comwith Copy, Try againglab uses the same words, with GitLab, glab and "merge request".
A host the person does not already use never gets a command or a "signed in" claim. It gets the hover card's plain line instead: "Details show for hosts your gh is signed in to. This one isn't, so nothing was fetched." The card still offers Try again.
Which hosts a command may name
There is one rule (
commandHostTrustedin@plannotator/core/problem-words), and every surface uses it. A command can name only:Any other host gets no command: a look-alike like
github.cornorgitlab-acme.com, or any host that only an agent's link named.gh auth login --hostname <look-alike>would send the person's sign-in to whoever runs that host. A link whose host only starts like a public forge (gitlab.com.evil.example) is not read as a forge link at all.What changed
auth status --hostnamecheck decides; it has its own 3 s deadline.?retry=1reads the CLI's hosts and the status check again, so the card recovers right after a sign-in.problem(code, title, line, action, retry). The tool's own output stays on the server. Older windows keep readingerror.@plannotator/core0.25.32 adds./problemand./problem-words. ui pins it; see packages/ui/HANDOFF.md.tests/inbox-size-ceilings.json,packages/inbox/api.tsgoes down to 2375 lines."Ask your agent to look" is no longer in this PR. It is kept on the branch
feat/inbox-ask-agent-to-look, which has no PR.Checked
e2e: inbox-pull-marker-hang.spec.ts