Repository navigation
Revert "Fix predictive back completion before transitions are composed" - #1070
Merged
Merged
Conversation
Reverts: #1057 It didn't fix the problem entirely. It still asks for PredictiveBackAnimatable in onBackProgressed, and then might discard the animatable, which is incorrect. A `PredictiveBackAnimatable` should animate and complete/cancel if created.
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts: #1057
It didn't fix the problem entirely. It still asks for PredictiveBackAnimatable in onBackProgressed, and then might discard the animatable, which is incorrect. A
PredictiveBackAnimatableshould animate and complete/cancel if created.