Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## branch-1.11 #7798 +/- ##
===========================================
Coverage 0.00% 0.00%
===========================================
Files 698 698
Lines 43682 43682
Branches 5899 5899
===========================================
Misses 43682 43682 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pan3793
added a commit
that referenced
this pull request
Oct 28, 2026
### Why are the changes needed? Fix two compatibility failures in the [branch-1.11 CI run](https://github.com/apache/kyuubi/actions/runs/40306781716): 1. The nondeterministic CTE test expects `RepartitionByExpression`, but Spark 3.3 uses `Repartition`. Check their shared `RepartitionOperation` superclass while retaining the value-equality and exchange-reuse assertions. 2. The JDBC lineage test fails with `No suitable driver` on Spark 3.3/3.4 with JDK 8. Initialize Derby explicitly in the test classloader before opening the JDBC connection. No production code or runtime dependencies change. ### How was this patch tested? Existing suites cover both fixes. 1. Reproduced the JDBC lineage failure on the base branch with Spark 3.3.4/JDK 8. 2. Spark 3.3.4/JDK 8: 79 lineage tests passed, 2 version-inapplicable tests canceled, and all 52 `HiveCatalogRangerSparkExtensionSuite` tests passed. 3. `dev/reformat` and `git diff --check` passed. With JDK 8 selected: ```bash build/mvn -B -ntp test \ -pl extensions/spark/kyuubi-spark-lineage,extensions/spark/kyuubi-spark-authz -am \ -Pspark-3.3,spark-provided,flink-provided,hive-provided \ -Dtest=none \ -DwildcardSuites=org.apache.kyuubi.plugin.lineage,org.apache.kyuubi.plugin.spark.authz.ranger.HiveCatalogRangerSparkExtensionSuite \ -Drat.skip=true dev/reformat git diff --check ``` The full CI matrix was not run locally. ### Was this patch assisted by generative AI tooling? Assisted-by: DeepSeek Harness:gpt-6.1-sol Closes #7798 from pan3793/branch-1.11-ci-fix. Closes #7798 b69f8f4 [Cheng Pan] [1.11] Keep CI fix scoped to Spark test compatibility 476b7ec [Cheng Pan] [1.11] Fix test compatibility and engine deletion timing Authored-by: Cheng Pan <pan3793@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
Author
|
Merge Summary:
Posted by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fix two compatibility failures in the branch-1.11 CI run:
RepartitionByExpression, but Spark 3.3 usesRepartition. Check their sharedRepartitionOperationsuperclass while retaining the value-equality and exchange-reuse assertions.No suitable driveron Spark 3.3/3.4 with JDK 8. Initialize Derby explicitly in the test classloader before opening the JDBC connection.No production code or runtime dependencies change.
How was this patch tested?
Existing suites cover both fixes.
HiveCatalogRangerSparkExtensionSuitetests passed.dev/reformatandgit diff --checkpassed.With JDK 8 selected:
build/mvn -B -ntp test \ -pl extensions/spark/kyuubi-spark-lineage,extensions/spark/kyuubi-spark-authz -am \ -Pspark-3.3,spark-provided,flink-provided,hive-provided \ -Dtest=none \ -DwildcardSuites=org.apache.kyuubi.plugin.lineage,org.apache.kyuubi.plugin.spark.authz.ranger.HiveCatalogRangerSparkExtensionSuite \ -Drat.skip=true dev/reformat git diff --checkThe full CI matrix was not run locally.
Was this patch assisted by generative AI tooling?
Assisted-by: DeepSeek Harness:gpt-6.1-sol