Repository navigation
[CALCITE-7872] Validate pull request titles and require a single matching commit - #5347
xiedeyantu wants to merge 2 commits into
Conversation
|
I think you should allow multiple commits, but require 1 to fit exactly |
My initial idea was to spare those with write access from having to spend extra time verifying these details—essentially allowing this CI check to fail during the PR review process, provided that its final status is "passed". I am currently still exploring ways to better verify that the logic aligns with expectations. |
xiedeyantu
changed the title
xiedeyantu
changed the title
xiedeyantu
changed the title
a9c186f to
9fd571e
Compare
| https://issues.apache.org/jira/projects/CALCITE/issues | ||
| *Check existing issues first to avoid duplicates.* | ||
| *Note: A Jira is NOT required for typos and cosmetic changes (i.e., changes that are neither bugs nor features).* | ||
| *Exceptions: Use `[TEST]` for test additions or `[MINOR]` for other minor changes, such as typos and cosmetic changes. These prefixes do not require a Jira issue.* |
There was a problem hiding this comment.
Are we covering all cases here? What about Site: ... PRs? Or Bump... PRs from dependabot?
There was a problem hiding this comment.
You’re right—the current "allowlist" is too restrictive. Looking at the local commit history, I see that it includes not only updates from Site: and Dependabot, but also reverts and descriptive titles used for tests or minor changes.
Furthermore, the existing LintTest rejects prefixes that don’t follow the Jira format (such as [MINOR]), which means the [TEST] / [MINOR] convention I introduced conflicts with the current validation rules.
I suggest the following: if a title contains a Jira prefix, we validate the corresponding Jira reference; otherwise, we allow descriptive titles without a Jira prefix—bypassing validation for these cases to provide more flexibility. This would eliminate the need to maintain an ever-growing list of "special prefixes." What do you think?
zabetak
added
the
discussion-in-jira
9fd571e to
0c70493
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
xiedeyantu
changed the title
5 participants
Jira Link
CALCITE-7871
Changes Proposed
See CALCITE-7871