Repository navigation
Conversation
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR resolves a 409 Conflict test flake in DicomIOReadIT by replacing the hardcoded storeName ("foo") with a dynamically generated unique name in setup(). The change is clean, minimal, and consistent with existing healthcare integration tests like HL7v2IOReadIT.
🔍 General Feedback
- The store name generation logic matches the pattern established across other GCP Healthcare IO integration tests and ensures test isolation across concurrent runs.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flake in
DicomIOReadIT(PreCommit Java GCP IO Directrun https://github.com/apache/beam/actions/runs/42336715354/job/128295165204):Root Cause
Unlike all other Healthcare integration tests (
HL7v2IOReadIT,FhirIOReadIT, etc.),DicomIOReadIThardcodedstoreName = "foo", causing concurrent test runs (or runs after a prior aborted test) to collide ondicomStores?dicomStoreId=foowith409 Conflict: already exists.Changes
storeName("DICOM_store_" + System.currentTimeMillis() + "_" + new SecureRandom().nextInt(32) + "_read_it") inDicomIOReadIT.setup(), matchingHL7v2IOReadITandFhirIOReadIT.Verification
PreCommit Java GCP IO Directworkflow run on this branch: https://github.com/apache/beam/actions/runs/42341086140