Repository navigation
Conversation
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR mitigates flaky Gradle wrapper download failures in CI by increasing networkTimeout in gradle-wrapper.properties from 10s to 60s and adding a 3-attempt bootstrap retry loop in gradle-command-self-hosted-action when the distribution cache is missing. The changes are concise, safe, and directly address the transient network errors observed in GitHub Actions runs.
🔍 General Feedback
- Increasing
networkTimeoutto60000(60s) is well-suited for downloading the ~137MB Gradle distribution over variable CI network connections. - Checking for the
.okmarker file before running./gradlew --version --no-daemonavoids adding overhead when the Gradle distribution is already cached, while still allowing the main Gradle invocation to run and surface any persistent errors if all retry attempts fail.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flaky Gradle wrapper download failures in
Java Tests(e.g. https://github.com/apache/beam/actions/runs/42317153978SocketTimeoutException: Read timed out, https://github.com/apache/beam/actions/runs/42045645481HTTP response code: 504, and https://github.com/apache/beam/actions/runs/41878489533SSLHandshakeExceptionwhen downloadinggradle-8.14.3-bin.zip).networkTimeoutingradle/wrapper/gradle-wrapper.propertiesfrom10000(10s) to60000(60s) so downloading the 137MB Gradle distribution does not time out on brief socket read stalls..github/actions/gradle-command-self-hosted-action/action.yml, when the Gradle wrapper distribution is not already present in$GRADLE_USER_HOME/wrapper/dists, runs./gradlew --version --no-daemonin a 3-attempt retry loop before executing the main Gradle command.Verification
Java Testson this branch: https://github.com/apache/beam/actions/runs/42322290668