Repository navigation
Removed openFile wait loop - #6618
Merged
Merged
Conversation
Same change as in apache#6493
utafrali
approved these changes
Oct 28, 2026
utafrali
left a comment
utafrali
left a comment
There was a problem hiding this comment.
The removal of the busy-wait spin loop is correct and strictly an improvement. future.get() already blocks until the future completes and throws InterruptedException on interruption, making the 10ms polling loop pure overhead with no behavioral difference. The existing catch blocks for InterruptedException, CancellationException, and ExecutionException cover all cases the old loop addressed.
ddanielr
approved these changes
Oct 28, 2026
Amemeda
approved these changes
Oct 28, 2026
dlmarion
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as in #6493